Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Infinispan Service Binding #30268

Merged
merged 1 commit into from
Jan 10, 2023
Merged

Infinispan Service Binding #30268

merged 1 commit into from
Jan 10, 2023

Conversation

karesti
Copy link
Member

@karesti karesti commented Jan 9, 2023 •
edited
Loading

Implements the Service Binding capability

Closes #29740

@karesti karesti added the area/infinispan Infinispan label Jan 9, 2023
@karesti karesti mentioned this pull request Jan 9, 2023
Closed
@karesti karesti requested review from wburns and gsmet January 10, 2023 08:51
@gsmet
Copy link
Member

gsmet commented Jan 10, 2023

@geoand is it you who is the most aware about service binding?

@geoand
Copy link
Contributor

geoand commented Jan 10, 2023

Indeed!

geoand
geoand approved these changes Jan 10, 2023
View reviewed changes
Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't say much about the Infinispan specific stuff, but the integration looks good

@geoand geoand merged commit fbbb5e8 into quarkusio:main Jan 10, 2023
@quarkus-bot quarkus-bot bot added this to the 2.16 - main milestone Jan 10, 2023
@quarkus-bot quarkus-bot bot added the kind/enhancement New feature or request label Jan 10, 2023
@karesti karesti deleted the infinispan-service-binding branch January 10, 2023 14:56
@wburns
Copy link
Member

wburns commented Jan 10, 2023

Looks fine to me as well from the Infinispan side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoand geoand geoand approved these changes

@wburns wburns Awaiting requested review from wburns

@gsmet gsmet Awaiting requested review from gsmet

Assignees
No one assigned
Labels
area/infinispan Infinispan kind/enhancement New feature or request
Projects
None yet
Milestone
2.16.0.CR1
Development

Successfully merging this pull request may close these issues.

Infinispan client should support Kubernetes Service Binding
4 participants
@karesti @gsmet @geoand @wburns