Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reactive Rest Client: Process paths before sub resources #29821

Merged
merged 1 commit into from
Dec 13, 2022

Conversation

Sgitario
Copy link
Contributor

@Sgitario Sgitario commented Dec 13, 2022

With these changes, we will apply the @PathParam parameters to the web target before passing it to the sub-resource instance.

Fix #29712

@Sgitario Sgitario requested a review from geoand December 13, 2022 05:39
Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@geoand geoand added triage/waiting-for-ci Ready to merge when CI successfully finishes triage/backport? triage/backport-2.13 labels Dec 13, 2022
@quarkus-bot
Copy link

quarkus-bot bot commented Dec 13, 2022

Failing Jobs - Building 2c7a295

Status Name Step Failures Logs Raw logs
✔️ JVM Tests - JDK 11
✔️ JVM Tests - JDK 17
JVM Tests - JDK 17 MacOS M1 Set up runner ⚠️ Check → Logs Raw logs
✔️ JVM Tests - JDK 18

@geoand geoand merged commit 0a79d6a into quarkusio:main Dec 13, 2022
@quarkus-bot quarkus-bot bot added this to the 2.16 - main milestone Dec 13, 2022
@quarkus-bot quarkus-bot bot added kind/bugfix and removed triage/waiting-for-ci Ready to merge when CI successfully finishes labels Dec 13, 2022
@Sgitario Sgitario deleted the 29712 branch December 13, 2022 06:41
@gsmet gsmet modified the milestones: 2.16 - main, 2.13.6.Final Dec 14, 2022
pjgg pushed a commit to pjgg/quarkus-test-suite that referenced this pull request Jan 14, 2023
…nario

There is an issue in upstream (quarkusio/quarkus#29821) that
only happends under some RestClient definition hierarchy.

This commit reproduces the problem in Quarkus 2.12 and earlier versions
pjgg pushed a commit to pjgg/quarkus-test-suite that referenced this pull request Jan 14, 2023
…nario

There is an issue in upstream (quarkusio/quarkus#29821) that
only happens under some RestClient definition hierarchy.

This commit reproduces the problem in Quarkus 2.12 and earlier versions
pjgg pushed a commit to pjgg/quarkus-test-suite that referenced this pull request Jan 14, 2023
…nario

There is an issue in upstream (quarkusio/quarkus#29821) that
only happens under some RestClient definition hierarchy.

This commit reproduces the problem in Quarkus 2.12 and earlier versions
pjgg pushed a commit to pjgg/quarkus-test-suite that referenced this pull request Jan 16, 2023
…nario

There is an issue in upstream (quarkusio/quarkus#29821) that
only happens under some RestClient definition hierarchy.

This commit reproduces the problem in Quarkus 2.12 and earlier versions
pjgg pushed a commit to pjgg/quarkus-test-suite that referenced this pull request Jan 16, 2023
…nario

There is an issue in upstream (quarkusio/quarkus#29821) that
only happens under some RestClient definition hierarchy.

This commit reproduces the problem in Quarkus 2.12 and earlier versions
pjgg pushed a commit to pjgg/quarkus-test-suite that referenced this pull request Jan 16, 2023
…nario

There is an issue in upstream (quarkusio/quarkus#29821) that
only happens under some RestClient definition hierarchy.

This commit reproduces the problem in Quarkus 2.12 and earlier versions
pjgg pushed a commit to quarkus-qe/quarkus-test-suite that referenced this pull request Jan 16, 2023
…nario (#995)

There is an issue in upstream (quarkusio/quarkus#29821) that
only happens under some RestClient definition hierarchy.

This commit reproduces the problem in Quarkus 2.12 and earlier versions
pjgg pushed a commit to pjgg/quarkus-test-suite that referenced this pull request Jan 17, 2023
…nario

There is an issue in upstream (quarkusio/quarkus#29821) that
only happens under some RestClient definition hierarchy.

This commit reproduces the problem in Quarkus 2.12 and earlier versions

(cherry picked from commit 0ffedd5)
pjgg pushed a commit to quarkus-qe/quarkus-test-suite that referenced this pull request Jan 18, 2023
… and subpath params and Request Scope event Propagation (#1000)

* Test Extended Architecture (XA) connection

Provides coverage for https://issues.redhat.com/browse/QUARKUS-2742

(cherry picked from commit ce15b26)

* Improve reactive rest client "process paths before sub resources" scenario

There is an issue in upstream (quarkusio/quarkus#29821) that
only happens under some RestClient definition hierarchy.

This commit reproduces the problem in Quarkus 2.12 and earlier versions

(cherry picked from commit 0ffedd5)

* New Scenario: RequestScope custom context was removed after `javax.enterprise` event propagation

When firing an async CDI Event, the requestScope context from the emitter briefly exists for the observer
and is then terminated. This commit is a reproducer of this scenario that happens on Quarkus 2.13.0.Final

(cherry picked from commit ef3eed6)

* Fix main pom docker image reference. 'postgresql.13.image' should be used in Quarkus 2.13

Co-authored-by: Fedor Dudinskiy <[email protected]>
pjgg pushed a commit to pjgg/quarkus-test-suite that referenced this pull request Jan 30, 2023
…nario (quarkus-qe#995)

There is an issue in upstream (quarkusio/quarkus#29821) that
only happens under some RestClient definition hierarchy.

This commit reproduces the problem in Quarkus 2.12 and earlier versions

(cherry picked from commit 2350b46)
pjgg pushed a commit to pjgg/quarkus-test-suite that referenced this pull request Jan 30, 2023
…nario (quarkus-qe#995)

There is an issue in upstream (quarkusio/quarkus#29821) that
only happens under some RestClient definition hierarchy.

This commit reproduces the problem in Quarkus 2.12 and earlier versions

(cherry picked from commit 2350b46)
pjgg pushed a commit to quarkus-qe/quarkus-test-suite that referenced this pull request Feb 1, 2023
… modules (#1021)

* Test Extended Architecture (XA) connection

Provides coverage for https://issues.redhat.com/browse/QUARKUS-2742

(cherry picked from commit ce15b26)

* Improve reactive rest client "process paths before sub resources" scenario (#995)

There is an issue in upstream (quarkusio/quarkus#29821) that
only happens under some RestClient definition hierarchy.

This commit reproduces the problem in Quarkus 2.12 and earlier versions

(cherry picked from commit 2350b46)

* New Scenario: RequestScope custom context was removed after `javax.enterprise` event propagation

When firing an async CDI Event, the requestScope context from the emitter briefly exists for the observer
and is then terminated. This commit is a reproducer of this scenario that happens on Quarkus 2.13.0.Final

(cherry picked from commit ef3eed6)

* gRPC and SSE coverage for OpenTelemetry

(cherry picked from commit f327c60)

* Add coverage to eventbus '@ConsumeEvent' annotation

(cherry picked from commit 7da0d4b)

* Drop duplicated definition of quarkus-opentelemetry

(cherry picked from commit b0cba7f)

* OutboundSseEvent is not correctly serialized

(cherry picked from commit 99b5eb1)

* Check, that dev-mode is omitted on projects with pom packaging

Required for QUARKUS-2757

(cherry picked from commit 4fd38c7)

* Refactoring of QUARKUS-2748: adding http test and improving error messages

(cherry picked from commit 6563431)

* Add test for security annotations in rest-data-panache (#994)

Quarkus extensions based on `rest-data-panache` support propagation of
security annotations into generated JAX-RS resources.
These tests provide coverage of this feature for extensions:
- `quarkus-hibernate-orm-rest-data-panache`
- `quarkus-spring-data-rest`

See also related test plan:
- https://github.com/quarkus-qe/quarkus-test-plans/blob/main/QUARKUS-2788.md

(cherry picked from commit 3f7a4c8)

* Add transaction-API classic scenario

(cherry picked from commit 509d491)

* Cover Vert.X-specific metrics. (#1019)

Add new module, which uses Vert.X-based HTTP server
Verify, that it works, and that it creates all required metrics
Required for https://issues.redhat.com/browse/QUARKUS-2829

(cherry picked from commit 818837f)

* Add missing opentelemetry exporter to Narayana scenario

---------

Co-authored-by: Fedor Dudinskiy <[email protected]>
Co-authored-by: Rostislav Svoboda <[email protected]>
Co-authored-by: Josef Smrcka <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

keycloak-admin-client-reactive maps wrong id to AuthorizationResources
3 participants