-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Register @ConfigMappings directly into the Config builder #20103
Conversation
If we agree with the solution, the documentation also needs to be updated. |
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building ff93946
Full information is available in the Build summary check run. Failures⚙️ JVM Tests - JDK 11 #- Failing: devtools/cli
📦 devtools/cli✖
⚙️ JVM Tests - JDK 11 Windows #- Failing: devtools/cli
📦 devtools/cli✖
⚙️ JVM Tests - JDK 16 #- Failing: devtools/cli
📦 devtools/cli✖
|
ff93946
to
64783e6
Compare
Added documentation. |
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building 64783e6
Full information is available in the Build summary check run. Failures⚙️ Native Tests - Security3 #- Failing: integration-tests/vault-agroal
📦 integration-tests/vault-agroal✖
✖
✖
|
64783e6
to
d6edb37
Compare
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building d6edb37
Full information is available in the Build summary check run. Failures⚙️ Gradle Tests - JDK 11 Windows #- Failing: integration-tests/gradle
📦 integration-tests/gradle✖
|
d6edb37
to
6675260
Compare
This workflow status is outdated as a new workflow run has been triggered. ✖ This workflow run has failed but no jobs reported an error. Something weird happened, please check the workflow run page carefully: it might be an issue with the workflow configuration itself. |
This will need a rebase |
Furthemore, if this is going to be part of |
Ok, give me a sec. |
6675260
to
d6970e1
Compare
Try to resolve the issue caused by the revert of #19937 in another way.
In the same way, we did with the
ConfigSource
for static init, where we added the@StaticInitSafe
annotation in #17483 to register the source with static init, I've reused the annotation to also mark the mapping as safe to be used during static init, so a mapping is only registered during static init if it is annotated with the@StaticInitSafe
annotation.