Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register @ConfigMappings directly into the Config builder #20103

Merged
merged 1 commit into from
Sep 29, 2021

Conversation

radcortez
Copy link
Member

@radcortez radcortez commented Sep 13, 2021

Try to resolve the issue caused by the revert of #19937 in another way.

In the same way, we did with the ConfigSource for static init, where we added the @StaticInitSafe annotation in #17483 to register the source with static init, I've reused the annotation to also mark the mapping as safe to be used during static init, so a mapping is only registered during static init if it is annotated with the @StaticInitSafe annotation.

@quarkus-bot quarkus-bot bot added area/arc Issue related to ARC (dependency injection) area/config area/core area/hibernate-validator Hibernate Validator labels Sep 13, 2021
@radcortez
Copy link
Member Author

If we agree with the solution, the documentation also needs to be updated.

@quarkus-bot
Copy link

quarkus-bot bot commented Sep 13, 2021

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building ff93946

Status Name Step Failures Logs Raw logs
JVM Tests - JDK 11 Build Failures Logs Raw logs
JVM Tests - JDK 11 Windows Build Failures Logs Raw logs
JVM Tests - JDK 16 Build Failures Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 11 #

- Failing: devtools/cli 

📦 devtools/cli

io.quarkus.cli.CliProjectJBangTest.testCreateAppOverrides line 82 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 
Expected OK return code.result: {
  exitCode: {2},

⚙️ JVM Tests - JDK 11 Windows #

- Failing: devtools/cli 

📦 devtools/cli

io.quarkus.cli.CliProjectJBangTest.testCreateAppOverrides line 82 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 
Expected OK return code.result: {
  exitCode: {2},

⚙️ JVM Tests - JDK 16 #

- Failing: devtools/cli 

📦 devtools/cli

io.quarkus.cli.CliProjectJBangTest.testCreateAppOverrides line 82 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 
Expected OK return code.result: {
  exitCode: {2},

@radcortez
Copy link
Member Author

Added documentation.

@quarkus-bot
Copy link

quarkus-bot bot commented Sep 14, 2021

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building 64783e6

Status Name Step Failures Logs Raw logs
Native Tests - Security3 Build Failures Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ Native Tests - Security3 #

- Failing: integration-tests/vault-agroal 

📦 integration-tests/vault-agroal

io.quarkus.vault.AgroalVaultITCase. - More details - Source on GitHub

java.lang.RuntimeException: Error waiting for test resource future to finish.
	at io.quarkus.test.common.TestResourceManager.waitForAllFutures(TestResourceManager.java:151)
	at io.quarkus.test.common.TestResourceManager.start(TestResourceManager.java:136)

io.quarkus.vault.AgroalVaultKv1ITCase. - More details - Source on GitHub

java.lang.RuntimeException: Error waiting for test resource future to finish.
	at io.quarkus.test.common.TestResourceManager.waitForAllFutures(TestResourceManager.java:151)
	at io.quarkus.test.common.TestResourceManager.start(TestResourceManager.java:136)

io.quarkus.vault.VaultKv1ITCase. - More details - Source on GitHub

java.lang.RuntimeException: Error waiting for test resource future to finish.
	at io.quarkus.test.common.TestResourceManager.waitForAllFutures(TestResourceManager.java:151)
	at io.quarkus.test.common.TestResourceManager.start(TestResourceManager.java:136)

@quarkus-bot
Copy link

quarkus-bot bot commented Sep 17, 2021

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building d6edb37

Status Name Step Failures Logs Raw logs
Gradle Tests - JDK 11 Windows Build Failures Logs Raw logs
✔️ JVM Tests - JDK 11
JVM Tests - JDK 16 Build ⚠️ Check → Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ Gradle Tests - JDK 11 Windows #

- Failing: integration-tests/gradle 

📦 integration-tests/gradle

io.quarkus.gradle.devmode.BasicKotlinApplicationModuleDevModeTest.main line 18 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.test.devmode.util.DevModeTestUtils that uses java.util.function.Supplier, java.util.function.Supplierjava.util.concurrent.atomic.AtomicReference, java.util.concurrent.atomic.AtomicReferencejava.lang.String, java.lang.Stringboolean was not fulfilled within 1 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:166)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

@quarkus-bot
Copy link

quarkus-bot bot commented Sep 27, 2021

This workflow status is outdated as a new workflow run has been triggered.

✖ This workflow run has failed but no jobs reported an error. Something weird happened, please check the workflow run page carefully: it might be an issue with the workflow configuration itself.

@geoand
Copy link
Contributor

geoand commented Sep 28, 2021

This will need a rebase

@geoand
Copy link
Contributor

geoand commented Sep 28, 2021

Furthemore, if this is going to be part of 2.3.0.Final, it needs to be in by tonight

@radcortez
Copy link
Member Author

Ok, give me a sec.

@quarkus-bot
Copy link

quarkus-bot bot commented Sep 28, 2021

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building d6970e1

Status Name Step Failures Logs Raw logs
JVM Tests - JDK 11 Build ⚠️ Check → Logs Raw logs
✔️ JVM Tests - JDK 17
MicroProfile TCKs Tests Verify ⚠️ Check → Logs Raw logs

@geoand geoand merged commit 5729c3f into quarkusio:main Sep 29, 2021
@quarkus-bot quarkus-bot bot added this to the 2.4 - main milestone Sep 29, 2021
@geoand geoand modified the milestones: 2.4 - main, 2.3.0.Final Sep 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment