Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move @StaticInitSafe annotation to the proper package #18755

Merged
merged 1 commit into from
Jul 16, 2021

Conversation

radcortez
Copy link
Member

@radcortez radcortez commented Jul 16, 2021

Follow up of #17483. Noticed that the annotation is not in the right location.

Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. I must admit that both worked for me :).

@gsmet gsmet added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jul 16, 2021
@radcortez
Copy link
Member Author

Indeed. But I notice we have all the annotations in the other package :)

@kenfinnigan kenfinnigan merged commit 10afdd3 into quarkusio:main Jul 16, 2021
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jul 16, 2021
@quarkus-bot quarkus-bot bot added this to the 2.2 - main milestone Jul 16, 2021
@gsmet
Copy link
Member

gsmet commented Jul 19, 2021

AFAICS, this was introduced in 2.1 so removing the 2.0 backport label.

@gsmet gsmet modified the milestones: 2.2 - main, 2.1.0.Final Jul 19, 2021
@radcortez
Copy link
Member Author

AFAICS, this was introduced in 2.1 so removing the 2.0 backport label.

Yes. That is why I also pushed now, so we don't have to deprecate stuff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants