Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove JDK 8 #16418

Merged
merged 6 commits into from
Apr 14, 2021
Merged

Remove JDK 8 #16418

merged 6 commits into from
Apr 14, 2021

Conversation

gastaldi
Copy link
Contributor

JDK 11 is now the minimum to build Quarkus

@gastaldi gastaldi requested review from gsmet and famod April 10, 2021 19:35
@quarkus-bot quarkus-bot bot added area/arc Issue related to ARC (dependency injection) area/dependencies Pull requests that update a dependency file area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/infra-automation anything related to CI, bots, etc. that are used to automated our infrastructure area/platform Issues related to definition and interaction with Quarkus Platform labels Apr 10, 2021
gsmet
gsmet requested changes Apr 10, 2021
View reviewed changes
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, thanks! I had it on my list but even better if someone else does it :).

I think there are a few more to update such as all the Gradle projects. See here when I had to go the other way: https://github.com/quarkusio/quarkus/pull/16137/files (and all the other projects were targeting Java 8).

@quarkus-bot quarkus-bot bot added the area/gradle Gradle label Apr 10, 2021
@gastaldi gastaldi marked this pull request as draft April 10, 2021 20:37
famod
famod requested changes Apr 10, 2021
View reviewed changes
Copy link
Member

@famod famod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+💯 for kicking it out!

There are a few profile activations related to JDK 8, e.g. this in build-parent:

        <profile>
            <id>jdk-8-classpath</id>
            <activation>
                <!-- activate this on any JDK from 9 onwards -->
                <jdk>[9,)</jdk>
            </activation>
            <properties>
                <maven.compiler.release>8</maven.compiler.release>
            </properties>
        </profile>

I think <jdk> is a good search term to find all.

pom.xml Show resolved Hide resolved
@quarkus-bot
Copy link

quarkus-bot bot commented Apr 10, 2021 •
edited
Loading

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building b80b66b

Status Name Step Test failures Logs Raw logs
✖ JVM Tests - JDK 15 Build Test failures Logs Raw logs
✖ Native Tests - Windows - hibernate-validator Build ⚠️ Check → Logs Raw logs

Test Failures

⚙️ JVM Tests - JDK 15 #

📦 integration-tests/kafka

✖ io.quarkus.it.kafka.SaslKafkaConsumerTest.testReception line 48 - Source on GitHub
✖ io.quarkus.it.kafka.SslKafkaConsumerTest.testReception line 56 - Source on GitHub

@quarkus-bot
Copy link

quarkus-bot bot commented Apr 10, 2021 •
edited
Loading

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building 5f6ac82

Status Name Step Test failures Logs Raw logs
✖ Native Tests - Windows - hibernate-validator Build ⚠️ Check → Logs Raw logs

@gastaldi
Copy link
Contributor Author

gastaldi commented Apr 11, 2021 •
edited
Loading

There is a bug in the maven-compiler-plugin 3.8.1-jboss-1: independent-modules/arc does not build when the jdk-8-classpath profile is removed. Any ideas @dmlloyd ?

UPDATE: This is fixed in 3.8.1-jboss-2 and there is PR updating jboss-parent in jboss/jboss-parent-pom#99

@famod
Copy link
Member

famod commented Apr 11, 2021

It just occured to me that once we merge this, backports might get more complicated as people will start using Java 11 APIs.

@gastaldi
Copy link
Contributor Author

It just occured to me that once we merge this, backports might get more complicated as people will start using Java 11 APIs.

This is planned for the 2.x releases. How would that be more complicated?

@famod
Copy link
Member

famod commented Apr 11, 2021

I meant as long as 1.x branches shall receive backports from main, issues like that could pop up.

@gastaldi gastaldi force-pushed the remove_jdk8 branch 2 times, most recently from 402d1f4 to ab65ac4 Compare April 12, 2021 15:38
@gastaldi gastaldi force-pushed the remove_jdk8 branch 2 times, most recently from 41fdce4 to 48995e9 Compare April 13, 2021 12:45
@gastaldi gastaldi marked this pull request as ready for review April 13, 2021 13:07
@gastaldi gastaldi requested a review from gsmet April 13, 2021 13:09
famod
famod requested changes Apr 13, 2021
View reviewed changes
Copy link
Member

@famod famod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the JDK 8 profiles in those three pom.xml should be removed as well:

  • extensions/grpc/deployment/pom.xml
  • integration-tests/grpc-mutual-auth/pom.xml
  • integration-tests/grpc-tls/pom.xml

It might then also be possible to remove boring-ssl from build-parent.

@quarkus-bot
Copy link

quarkus-bot bot commented Apr 13, 2021 •
edited
Loading

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building 48995e9

Status Name Step Test failures Logs Raw logs
✖ JVM Tests - JDK 11 Build Test failures Logs Raw logs
✔️ JVM Tests - JDK 11 Windows
✖ JVM Tests - JDK 15 Build Test failures Logs Raw logs
✖ Maven Tests - JDK 11 Build Test failures Logs Raw logs

Full information is available in the Build summary check run.

Test Failures

⚙️ JVM Tests - JDK 11 #

📦 integration-tests/kafka

✖ io.quarkus.it.kafka.SaslKafkaConsumerTest.testReception line 48 - More details - Source on GitHub

✖ io.quarkus.it.kafka.SslKafkaConsumerTest.testReception line 56 - More details - Source on GitHub

⚙️ JVM Tests - JDK 15 #

📦 integration-tests/kafka

✖ io.quarkus.it.kafka.SaslKafkaConsumerTest.testReception line 48 - More details - Source on GitHub

✖ io.quarkus.it.kafka.SslKafkaConsumerTest.testReception line 56 - More details - Source on GitHub

⚙️ Maven Tests - JDK 11 #

📦 integration-tests/maven

✖ io.quarkus.maven.it.DevMojoIT.testThatNewResourcesAreServed line 791 - More details - Source on GitHub

gastaldi added 6 commits April 13, 2021 14:40
@gastaldi
Remove JDK 8
7d27552 
JDK 11 is now the minimum to build Quarkus

Remove jdk-8-classpath profile

Remove jdk-8-classpath profile from independent projects

Update build.gradle

Fixed gradle tests
@gastaldi
Update .github/workflows/release-build.yml
602de53
@gastaldi
Bump plexus-component-metadata to 2.1.0
f82f0a7
@gastaldi
Error if QuarkusAugmentor runs in JDK 8
adfff60
@gastaldi
Configure enforcer plugin to build on JDK 11+
206595e
@gastaldi
Remove GRPC JDK 8 compatibility
21dc993
@quarkus-bot quarkus-bot bot added the area/grpc gRPC label Apr 13, 2021
@gastaldi gastaldi requested a review from famod April 13, 2021 17:49
@quarkus-bot
Copy link

quarkus-bot bot commented Apr 13, 2021

Failing Jobs - Building 21dc993

Status Name Step Test failures Logs Raw logs
✔️ JVM Tests - JDK 11
⌛ JVM Tests - JDK 11 Windows Build ⚠️ Check → Logs Raw logs
✖ JVM Tests - JDK 15 Build Test failures Logs Raw logs
✖ Maven Tests - JDK 11 Build Test failures Logs Raw logs
⌛ Native Tests - Messaging Build ⚠️ Check → Logs Raw logs

Full information is available in the Build summary check run.

Test Failures

⚙️ JVM Tests - JDK 15 #

📦 integration-tests/kafka

✖ io.quarkus.it.kafka.SaslKafkaConsumerTest.testReception line 48 - More details - Source on GitHub

✖ io.quarkus.it.kafka.SslKafkaConsumerTest.testReception line 56 - More details - Source on GitHub

⚙️ Maven Tests - JDK 11 #

📦 integration-tests/maven

✖ io.quarkus.maven.it.DevMojoIT.testThatNewResourcesAreServed line 791 - More details - Source on GitHub

famod
famod approved these changes Apr 13, 2021
View reviewed changes
Copy link
Member

@famod famod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now!

I've seen all those build failures before in other PRs so I don't think they are related.

@gastaldi
Copy link
Contributor Author

@famod thank you! I'll let @gsmet have the final say and merge this

@gsmet
Copy link
Member

gsmet commented Apr 14, 2021

I thought about adding a thumbs up to the PR but you have 11, which is perfect :).

Thanks for this, let's merge and iterate from there if we find other things to adapt.

@gsmet gsmet merged commit 0948d19 into quarkusio:main Apr 14, 2021
@quarkus-bot quarkus-bot bot added this to the 2.0 - main milestone Apr 14, 2021
@gastaldi gastaldi deleted the remove_jdk8 branch April 14, 2021 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivannov ivannov ivannov left review comments

@gsmet gsmet gsmet approved these changes

@famod famod famod approved these changes

Assignees
No one assigned
Labels
area/arc Issue related to ARC (dependency injection) area/core area/dependencies Pull requests that update a dependency file area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/gradle Gradle area/grpc gRPC area/infra-automation anything related to CI, bots, etc. that are used to automated our infrastructure area/maven area/platform Issues related to definition and interaction with Quarkus Platform
Projects
None yet
Milestone
2.0.0.Alpha1
Development

Successfully merging this pull request may close these issues.
4 participants
@gastaldi @famod @gsmet @ivannov