Updated RuntimeParamConverterTest with the new empty parameter behavior

quarkusio · Aug 22, 2024 · 494116b · 494116b
1 parent 2108e39
commit 494116b
Showing 1 changed file with 3 additions and 11 deletions.
diff --git a/...t/java/io/quarkus/resteasy/reactive/server/test/converters/RuntimeParamConverterTest.java b/...t/java/io/quarkus/resteasy/reactive/server/test/converters/RuntimeParamConverterTest.java
@@ -61,7 +61,7 @@ void sendEmptyParameter() {
                 .when().get("/param-converter")
                 .then()
                 .statusCode(200)
-                .body(Matchers.is("Hello! You provided an empty number."));
+                .body(Matchers.is("Hello, world! No number was provided."));
     }
 
     @ApplicationScoped
@@ -70,12 +70,8 @@ public static class ParamConverterEndpoint {
 
         @GET
         public Response greet(@QueryParam("number") Optional<Integer> numberOpt) {
-            if (numberOpt != null) {
-                if (numberOpt.isPresent()) {
-                    return Response.ok(String.format("Hello, %s!", numberOpt.get())).build();
-                } else {
-                    return Response.ok("Hello! You provided an empty number.").build();
-                }
+            if (numberOpt.isPresent()) {
+                return Response.ok(String.format("Hello, %s!", numberOpt.get())).build();
             } else {
                 return Response.ok("Hello, world! No number was provided.").build();
             }
@@ -108,10 +104,6 @@ public static class OptionalIntegerParamConverter implements ParamConverter<Opti
         @Override
         public Optional<Integer> fromString(String value) {
             if (value == null) {
-                return null;
-            }
-
-            if (value.trim().isEmpty()) {
                 return Optional.empty();
             }