Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Change waiting strategy for PG imgs from RH registry till FW is fixed" #2007

Conversation

michalvavrik
Copy link
Member

@michalvavrik michalvavrik commented Sep 13, 2024

Summary

This reverts commit c4ca78c that was part of the #1862. That commit did some moving to be able to disable tests when they run with RH images in OpenShift and keep running them with non-RH on baremetal.

We want to revert to the original behavior as it makes tests more stable only continuing when container is already listening. We can do that because it got fixed in quarkus-qe/quarkus-test-framework#1305.

Please select the relevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • Dependency update
  • Refactoring
  • Backport
  • New scenario (non-breaking change which adds functionality)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@michalvavrik
Copy link
Member Author

run tests

@michalvavrik
Copy link
Member Author

There is one failure in OpenShiftMariaDBDatabaseIT, that is 12:41:52,693 INFO mvn: Error: The heap snapshot verifier discovered a type not marked as reachable: AnalysisType<HotSpotDiagnosticMXBean$ThreadDumpFormat[] -> HotSpotType<[Lcom/sun/management/HotSpotDiagnosticMXBean$ThreadDumpFormat;, resolved>, allocated: false, inHeap: false, reachable: false>. However, inside sql-db/sql-app module changes are isolated to OpenShiftPostgresqlDatabaseIT and that tests passes, therefore I deem the failure unrelated.

@michalvavrik michalvavrik requested a review from mjurc September 13, 2024 13:18
Copy link
Member

@mjurc mjurc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides TodoDemoIT, LGTM

@mjurc mjurc merged commit 76627f0 into quarkus-qe:main Sep 13, 2024
9 of 10 checks passed
@michalvavrik michalvavrik deleted the feature/revrert-waiting-strategy-for-pg-rh-img branch September 13, 2024 14:55
fedinskiy pushed a commit to fedinskiy/quarkus-test-suite that referenced this pull request Sep 25, 2024
@fedinskiy fedinskiy mentioned this pull request Sep 25, 2024
9 tasks
fedinskiy pushed a commit to fedinskiy/quarkus-test-suite that referenced this pull request Sep 25, 2024
michalvavrik added a commit that referenced this pull request Sep 25, 2024
…fixed" (#2007)

This reverts commit c4ca78c.

(cherry picked from commit 76627f0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants