Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Profile for OpenShift running on aarch64 #1148

Merged
merged 9 commits into from
Apr 14, 2023

Conversation

mjurc
Copy link
Member

@mjurc mjurc commented Apr 2, 2023

Summary

This PR contains a new profile for ARM running on OpenShift; updates to containers running test services to multiarch version and exclusion for tests that do not have required test services running on aarch64.

Issues that will need to be addressed for complete coverage:

Test run with the profile: https://main-jenkins-csb-quarkusqe.apps.ocp-c1.prod.psi.redhat.com/job/quarkus-main-rhel8-jdk11-openshift-weekly-ts-jvm-ocp-4-stable/14/

Please select the relevant options.

  • [] Bug fix (non-breaking change which fixes an issue)
  • Dependency update
  • Refactoring
  • Backport
  • New scenario (non-breaking change which adds functionality)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@mjurc mjurc self-assigned this Apr 2, 2023
@rsvoboda rsvoboda requested a review from michalvavrik April 3, 2023 07:20
mjurc added 9 commits April 13, 2023 18:35
* Bumping bitnami/elasticsearch to 7.17.9 to make use of newer builds in
  same minor version with aarch64 builds.
* Adding openshift-arm and openshift-arm-containers profiles. Profiles
  are activated with openshift-arm property. The profiles bump some of
  the used containers to their versions with ARM architecture builds.
* Disabling serverless tests on ARM due to RH Serverless not supporting
  that architecture yet.
* Disabling tests using RH Streams Kafka on ARM on OpenShift as the
  standaolne container doesn't yet have a build supporting the
  architecture.
* Disabling tests using RH SSO standalone container on OCP on ARM as
  there is no release supporting that architecture yet.
* Disabling the MongoDB OCP tests from running on ARM as the current
  image is not multiarch and the official ARM  image would require
  some changes to the test.
* Disabling the tests that use RH AMQ Streams operator on ARM. This
  operator is not supported on that architecture.
* Bumping RHSCL MySQL to use the MySQL build based on RHEL 8, which also
  supports ARM.
* This container version is also multiarch.
@mjurc
Copy link
Member Author

mjurc commented Apr 13, 2023

run tests

@mjurc
Copy link
Member Author

mjurc commented Apr 13, 2023

@michalvavrik This should be ready now.

I don't think the failures are related to my PR - the failure comes from StrimziKafkaAvroGroupIdIT#testAlertMonitorEventStream in native and the devmode version in JVM mode (DevModeApicurioDevServiceUserExperienceIT) which I did not touch, and it takes up 90% of the log

I tried it locally but I don't see the deserialization issues.

@michalvavrik
Copy link
Member

@mjurc ok, I'll have a look first thing tomorrow.

@rsvoboda
Copy link
Member

I've seen the deserialization issue in quarkus-qe/quarkus-test-framework#731 (in the run after fixing dev mode and openshift/kubernetes cases)

Also not able to reproduce locally. Checked the recent PRs and quarkusio/quarkus@3414e59 looked suspicious.

@michalvavrik
Copy link
Member

definitely @rsvoboda , when I tried to raise apicurio/apicurio-registry-mem I always got this error (I tried it recently when upgrading Kafka images). I didn't debug this yet, tomorrow I'll try to reproduce it.

@mjurc
Copy link
Member Author

mjurc commented Apr 13, 2023

@michalvavrik with regards to postgres failures in the OpenShift run, the failure is related to image limit for pull from DockerHub (the AWS infra doesn't have mirroring set up yet), not to the changes. It is kinda interesting that we're getting that failure there, though.

Copy link
Member

@michalvavrik michalvavrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michalvavrik michalvavrik merged commit 1f9e757 into quarkus-qe:main Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants