Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Update Kafka utils to use images from Maven properties" #984

Merged
merged 1 commit into from
Dec 17, 2023
Merged

Revert "Update Kafka utils to use images from Maven properties" #984

merged 1 commit into from
Dec 17, 2023

Conversation

gtroitsk
Copy link
Member

@gtroitsk gtroitsk commented Dec 17, 2023 •
edited
Loading

Reverts #976

This update turned out to be a bad decision. It is not possible to retrieve systemProperties from FW parent POM to use in Quarkus QE TS, properties are ignored.

michalvavrik
michalvavrik approved these changes Dec 17, 2023
View reviewed changes
Copy link
Member

@michalvavrik michalvavrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was wrong to suggest doing this at the first place, apologies, thanks for the revert.

@michalvavrik michalvavrik merged commit 871ef99 into main Dec 17, 2023
@michalvavrik michalvavrik deleted the revert-976-rewrite-kafka-utils branch December 17, 2023 08:50
@gtroitsk gtroitsk mentioned this pull request Dec 17, 2023
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalvavrik michalvavrik michalvavrik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gtroitsk @michalvavrik