Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate from URL to URI constructor #903

Merged
merged 1 commit into from
Oct 16, 2023
Merged

Migrate from URL to URI constructor #903

merged 1 commit into from
Oct 16, 2023

Conversation

jedla97
Copy link
Member

@jedla97 jedla97 commented Oct 12, 2023

…ecated.

Summary

Hi, this PR updating some deprecated method. To be prepared to JDK 21.

URL constructors was deprecated in JDK 20. Now is possible to create URL from URI.

Please check the relevant options

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Dependency update
  • Refactoring
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Example scenarios has been updated / added
  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@jedla97
Copy link
Member Author

jedla97 commented Oct 12, 2023

run tests

@jedla97 jedla97 requested a review from mjurc October 12, 2023 12:57
@mjurc mjurc requested review from fedinskiy and jsmrcka and removed request for mjurc and fedinskiy October 12, 2023 13:35
jsmrcka
jsmrcka suggested changes Oct 13, 2023
View reviewed changes
Copy link
Contributor

@jsmrcka jsmrcka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A minor detail to be fixed, otherwise looks good.

@jedla97 jedla97 requested a review from jsmrcka October 15, 2023 21:31
@jedla97
Copy link
Member Author

jedla97 commented Oct 16, 2023

The error seems to appear in daily so not PR related

jsmrcka
jsmrcka approved these changes Oct 16, 2023
View reviewed changes
Copy link
Contributor

@jsmrcka jsmrcka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update. The PR failures are indeed unrelated. I am merging this.

@jsmrcka jsmrcka merged commit 71cd834 into quarkus-qe:main Oct 16, 2023
@jedla97 jedla97 deleted the jdk21-deprecation branch April 25, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsmrcka jsmrcka jsmrcka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jedla97 @jsmrcka