Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Container Image Jib extension with images based on UBI8 #1501

Conversation

michalvavrik
Copy link
Member

Summary

I'd like to test Container Image Jib extension with images based on UBI8 because this is the only place where we test this extension that is preview in the product. Also there is some specific behavior like determining runtime image based on Java version in which they were compiled. I'd like to have smoke tests that it works. (note: I didn't run this locally as I don't want to setup minikube with k8, so fingers crossed it works).

Please check the relevant options

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Dependency update
  • Refactoring
  • Release (follows conventions described in the RELEASE.md)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Example scenarios has been updated / added
  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@rsvoboda
Copy link
Member

JIB extension is not supported on product side

It has community preview status - https://code.quarkus.io/?extension-search=jib

TBH, I'm not sure if this extension is worth the effort you put into this PR

@michalvavrik
Copy link
Member Author

JIB extension is not supported on product side

It has community preview status - https://code.quarkus.io/?extension-search=jib

TBH, I'm not sure if this extension is worth the effort you put into this PR

I'd prefer if at least someone tested it, it helped me to discover this bug quarkusio/quarkus#46231, who else will know if it doesn't work? I think additions shouldn't take long of our execution time, but as I mentioned, didn't really try it.

Copy link
Member

@rsvoboda rsvoboda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, let's try it, we can always revert :)

@rsvoboda rsvoboda merged commit 1da41e2 into quarkus-qe:main Feb 20, 2025
5 checks passed
@michalvavrik michalvavrik deleted the feature/test-ubi8-with-jib-container-image-ext branch February 20, 2025 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants