Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tags are not pointing to the the correct commits #126

Closed
michael-simons opened this issue Jan 9, 2023 · 4 comments · Fixed by #141
Closed

Tags are not pointing to the the correct commits #126

michael-simons opened this issue Jan 9, 2023 · 4 comments · Fixed by #141
Assignees

Comments

@michael-simons
Copy link
Contributor

michael-simons commented Jan 9, 2023

I wonder if I am doing something wrong here: The release process correctly creates tags, but the commits are not on the main branch to which the tags point to.

Have a lock at 2.0.0 for example. It points to 657f65f

commit 657f65fb387b7f341867fc8965acc556dc9ddcb3 (tag: 2.0.0)
Author: GitHub Action <[email protected]>
Date:   Thu Dec 1 12:57:13 2022 +0000

    Update stable version for documentation

diff --git a/docs/modules/ROOT/pages/includes/attributes.adoc b/docs/modules/ROOT/pages/includes/attributes.adoc
index a08d7e0..367de13 100644
--- a/docs/modules/ROOT/pages/includes/attributes.adoc
+++ b/docs/modules/ROOT/pages/includes/attributes.adoc
@@ -1,5 +1,5 @@
 :quarkus-version: 2.14.2.Final
-:quarkus-neo4j-version: 1.7.1
+:quarkus-neo4j-version: 2.0.0
 :maven-version: 3.8.1+
 
 :quarkus-org-url: https://github.com/quarkusio

On the main the commit with the same change is

commit 149aef3a9b23fd8454b049ecdb3cabd681c11d98
Author: GitHub Action <[email protected]>
Date:   Thu Dec 1 12:53:41 2022 +0000

    Update stable version for documentation

diff --git a/docs/modules/ROOT/pages/includes/attributes.adoc b/docs/modules/ROOT/pages/includes/attributes.adoc
index a08d7e0..367de13 100644
--- a/docs/modules/ROOT/pages/includes/attributes.adoc
+++ b/docs/modules/ROOT/pages/includes/attributes.adoc
@@ -1,5 +1,5 @@
 :quarkus-version: 2.14.2.Final
-:quarkus-neo4j-version: 1.7.1
+:quarkus-neo4j-version: 2.0.0
 :maven-version: 3.8.1+
 
 :quarkus-org-url: https://github.com/quarkusio

Can we fix that somehow @gsmet ?

@maxandersen
Copy link
Member

@gastaldi ^

@gastaldi
Copy link
Member

That's because the tag is overwritten in https://github.com/quarkiverse/quarkus-neo4j/blob/8a07489505140071261d031610d4be3eb5572979/.github/workflows/release.yml#LL71C18-L71C18 when the documentation is generated for the released version.

We probably need to have a look at that part to avoid that

@gastaldi
Copy link
Member

Note however that this is the only commit that isn't in the main branch, so I am not sure this is a major issue TBH

@gastaldi
Copy link
Member

gastaldi commented Feb 11, 2023

@michael-simons take a look at quarkusio/quarkus#31046, that may fix this issue.

gastaldi added a commit that referenced this issue Feb 11, 2023
michael-simons pushed a commit that referenced this issue Feb 13, 2023
* Update release script

- Fixes #126

* Update build script
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants