Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: provide jackson jq extra as an independent module (#68) #69

Merged
merged 1 commit into from
Jan 12, 2023

Conversation

Jiehong
Copy link
Contributor

@Jiehong Jiehong commented Jan 9, 2023

No description provided.

.body("$", hasItem("strptime/1")) // extra function not filtered
.body("$", hasItem("strptime/2")) // extra function not filtered
.body("$", hasItem("timestamp/0")) // extra function not filtered
.body("$", hasItem("uuid4/0")); // extra function not filtered
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't create a new module just for testing the extra part, but those functions can only come from the extra jq module, so it should be fine IMO

<version>${jackson-jq.version}</version>
</dependency>
</dependencies>
</project>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

at this point, this only allows us to have quarkus-jackson-jq and quarkus-jackson-jq-extra pegged to the exact same version for users.

@Jiehong
Copy link
Contributor Author

Jiehong commented Jan 9, 2023

Tested locally:

$ mvn clean test
...
[INFO] 
[INFO] Results:
[INFO] 
[INFO] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0
[INFO] 
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary for Quarkus - Jackson Jq - Parent 1.2.0-SNAPSHOT:
[INFO] 
[INFO] Quarkus - Jackson Jq - Parent ...................... SUCCESS [  0.539 s]
[INFO] Quarkus - Jackson Jq - Runtime ..................... SUCCESS [  1.691 s]
[INFO] Quarkus - Jackson Jq - Runtime - Extra ............. SUCCESS [  0.014 s]
[INFO] Quarkus - Jackson Jq - Deployment .................. SUCCESS [  0.593 s]
[INFO] Quarkus - Jackson Jq - Integration Tests ........... SUCCESS [  4.679 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  7.635 s
[INFO] Finished at: 2023-01-09T21:20:17+01:00
[INFO] ------------------------------------------------------------------------

Copy link
Member

@ricardozanini ricardozanini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Have you tried on your local project?

@ricardozanini ricardozanini linked an issue Jan 10, 2023 that may be closed by this pull request
@Jiehong
Copy link
Contributor Author

Jiehong commented Jan 11, 2023

Nice! Have you tried on your local project?

Just did, and it works fine: extra functions are added only if the new dependency is added.

@ricardozanini ricardozanini merged commit 0c8de97 into quarkiverse:main Jan 12, 2023
@ricardozanini
Copy link
Member

@Jiehong let me know if you need anything else before since I'm planning to release a new version with this feature.

@ricardozanini
Copy link
Member

@all-contributors please add @Jiehong for code

@allcontributors
Copy link
Contributor

@ricardozanini

I've put up a pull request to add @Jiehong! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jq extra functions missing
3 participants