-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: provide jackson jq extra as an independent module (#68) #69
Conversation
.body("$", hasItem("strptime/1")) // extra function not filtered | ||
.body("$", hasItem("strptime/2")) // extra function not filtered | ||
.body("$", hasItem("timestamp/0")) // extra function not filtered | ||
.body("$", hasItem("uuid4/0")); // extra function not filtered |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't create a new module just for testing the extra part, but those functions can only come from the extra jq module, so it should be fine IMO
2a08583
to
0581003
Compare
<version>${jackson-jq.version}</version> | ||
</dependency> | ||
</dependencies> | ||
</project> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
at this point, this only allows us to have quarkus-jackson-jq
and quarkus-jackson-jq-extra
pegged to the exact same version for users.
Tested locally:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Have you tried on your local project?
Just did, and it works fine: extra functions are added only if the new dependency is added. |
@Jiehong let me know if you need anything else before since I'm planning to release a new version with this feature. |
@all-contributors please add @Jiehong for code |
I've put up a pull request to add @Jiehong! 🎉 |
No description provided.