Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade jackson-jq to 1.0.0 #209

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

jamesnetherton
Copy link
Contributor

Assuming this change is acceptable - any chance of having a new quarkus-jackson-jq release afterwards?

@jamesnetherton jamesnetherton requested a review from a team as a code owner October 1, 2024 08:54
Copy link
Contributor

@hbelmiro hbelmiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. We can release a new version once this is merged.

@hbelmiro hbelmiro requested a review from fjtirado October 1, 2024 13:59
@ricardozanini ricardozanini merged commit b14a0b9 into quarkiverse:main Oct 1, 2024
1 check passed
@jamesnetherton jamesnetherton deleted the jackson-jq-1.0.0 branch October 1, 2024 15:39
@ricardozanini
Copy link
Member

@jamesnetherton @oscerd here: https://github.com/quarkiverse/quarkus-jackson-jq/releases/tag/2.1.0

@ricardozanini
Copy link
Member

@jamesnetherton @oscerd unfortunately we can't release a new version because of this: https://github.com/quarkiverse/quarkiverse-release/actions/runs/11129100506/job/30925391635

The runtime-extra module is not a jar module and was added in the past so users could have the extra functions available in the scope.

The problem is that the fix won't fix the issue since the deployment module, as it is today, depends on it. Hence, it's adding the extras anyway!!

I don't have time to see this now, so we are blocked until I can fix it. The fix is simple. We must remove the extra module from the deployment module, update the docs to notify users about this change, and offer a new alternative to include the extras. The alternative must be a new module that users can add to their projects. Adding the extras from jq directly should do; in that case, we can create a BOM file to distribute.

@ricardozanini
Copy link
Member

@jamesnetherton @oscerd fixed here #214

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants