Support Protostream #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karesti
force-pushed
the
marshalling-example
branch
4 times, most recently
from
775304e to
d09cbca
Compare
karesti
force-pushed
the
marshalling-example
branch
2 times, most recently
from
a5c5700 to
db3c14a
Compare
karesti
force-pushed
the
marshalling-example
branch
from
db3c14a to
e782df8
Compare
ryanemerson
reviewed
Dec 13, 2024
| initializerClasses | ||
| .addAll(index.getAllKnownImplementors(DotName.createSimple(GeneratedSchema.class.getName()))); | ||
| Set<String> initializers = new HashSet<>(initializerClasses.size()); | ||
| for (ClassInfo ci : initializerClasses) { |
There was a problem hiding this comment.
Why do we need to load the class here? I'm not sure this will always work depending on the classpath (I could be wrong).
Can we not use public ServiceProviderBuildItem(String serviceInterfaceClassName, List<String> providers) which does not require a Class object?
There was a problem hiding this comment.
@ryanemerson This is the way it is done in the infinispan client to make it work. I don't know if what you mentions works, I will try
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds protostream marshalling
Closes #20
Closes #19