Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GitHubCustomizer #632

Merged
merged 2 commits into from
Jun 20, 2024
Merged

Add GitHubCustomizer #632

merged 2 commits into from
Jun 20, 2024

Conversation

ryandens
Copy link
Contributor

@ryandens ryandens commented Jun 19, 2024 •
edited
Loading

Fixes #628
Add seam for customizing GitHubBuilder's prior to instantiating Github clients

ryandens and others added 2 commits June 19, 2024 12:15
@ryandens
Add seam for customizing GitHubBuilder's prior to instantiating GitHu…
e555167 
…b clients
@gsmet
Some very minor refinements + doc
97244d2 
We usually try to avoid lambdas in runtime code as there is a small
price to pay.
In this case, they are easily avoidable.
gsmet
gsmet approved these changes Jun 20, 2024
View reviewed changes
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a small commit to add some doc + remove the lambda.

I let you have a look and confirm that it's all good for you before merging.

@ryandens
Copy link
Contributor Author

Looks good to me!

@gsmet gsmet merged commit 6d6832e into quarkiverse:main Jun 20, 2024
5 checks passed
@gsmet
Copy link
Member

gsmet commented Jun 20, 2024

Thanks for your contribution!

@gsmet
Copy link
Member

gsmet commented Jun 20, 2024

@allcontributors add @ryandens for code

@allcontributors allcontributors bot mentioned this pull request Jun 20, 2024
Merged
@allcontributors AllContributors
Copy link
Contributor

@gsmet

I've put up a pull request to add @ryandens! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsmet gsmet gsmet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow for configuration of the composed Hub4j GitHub instance
2 participants
@ryandens @gsmet