Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove io.quarkus:quarkus-jms-spi-deployment in build-parent #182

Merged
merged 1 commit into from
Mar 8, 2023
Merged

Remove io.quarkus:quarkus-jms-spi-deployment in build-parent #182

merged 1 commit into from
Mar 8, 2023

Conversation

zhfeng
Copy link
Contributor

@zhfeng zhfeng commented Mar 8, 2023

Fix #166

@zhfeng zhfeng linked an issue Mar 8, 2023 that may be closed by this pull request
Remove io.quarkus:quarkus-jms-spi-deployment in build-parent #167
Closed
@turing85
Copy link
Contributor

turing85 commented Mar 8, 2023

@zhfeng please ignore the failed job in the pipeline; it is a know issue on github-actions when run on a fork.

@turing85
Copy link
Contributor

turing85 commented Mar 8, 2023 •
edited
Loading

@zhfeng please hold back merging this PR. I asked for a change in the permissions for PRs, waiting on some feedback. If the change is granted and does what I think it does, the failing job should no longer fail. I would like to validate the change with this PR.

PR can be merged.

@zhfeng zhfeng merged commit b21aee4 into quarkiverse:main Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turing85 turing85 turing85 approved these changes

Assignees

@zhfeng zhfeng

Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove io.quarkus:quarkus-jms-spi-deployment in build-parent
2 participants
@zhfeng @turing85