Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support explicitly disabling dev services for cognito user pools #882

Merged
merged 1 commit into from
Aug 11, 2023

Conversation

emattheis
Copy link
Contributor

Copied implementation from base class used by other services:

// explicitely disabled
if (!devServicesBuildTimeConfig.enabled().orElse(true)) {
log.debugf(
"Not starting Dev Services for Amazon Services - %s, as it has been disabled in the config.",
enabledService.getName());
return null;
}

Addresses concern raised here: quarkusio/quarkus#34801 (comment)

@scrocquesel scrocquesel merged commit c31de63 into quarkiverse:main Aug 11, 2023
@scrocquesel
Copy link
Member

@all-contributors please add @emattheis for code

@allcontributors
Copy link
Contributor

@scrocquesel

@emattheis already contributed before to code

@emattheis emattheis deleted the cognito-dev-services branch August 11, 2023 17:43
scrocquesel added a commit that referenced this pull request Aug 14, 2023
…#886)

* fix: support explicitly disabling dev services for cognito user pools (#882)

* fix compile

---------

Co-authored-by: Erik Mattheis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants