Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add defaultBean qualifier for DynamoDbEnhancedClient synthetic beans #875

Merged
merged 1 commit into from
Aug 5, 2023

Conversation

scrocquesel
Copy link
Member

Fix #870

@scrocquesel
Copy link
Member Author

@DudekJakub Could you check this PR actually fix all the issue related to mocking both dynamodb enhanced client and clock ?
You can mvn install -DskipTests the branch and replace implementation(enforcedPlatform("${quarkusPlatformGroupId}:quarkus-amazon-services-bom:${quarkusPlatformVersion}")) to use io.quarkiverse.amazonservices:quarkus-amazon-services-bom:999-SNAPSHOT

@scrocquesel
Copy link
Member Author

@DudekJakub Could you check this PR actually fix all the issue related to mocking both dynamodb enhanced client and clock ? You can mvn install -DskipTests the branch and replace implementation(enforcedPlatform("${quarkusPlatformGroupId}:quarkus-amazon-services-bom:${quarkusPlatformVersion}")) to use io.quarkiverse.amazonservices:quarkus-amazon-services-bom:999-SNAPSHOT

Did the test on 3.2.2_DYNAMO_with_@DefaultBean_and_InjectMockk_ERROR, it passed with removing the @DefaultBean.

@scrocquesel scrocquesel marked this pull request as ready for review August 5, 2023 13:30
@scrocquesel scrocquesel merged commit 2044735 into quarkiverse:main Aug 5, 2023
@scrocquesel scrocquesel deleted the gh-870 branch August 5, 2023 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Quarkus 3.2.2.Final issue with DynamoDbEnhancedAsyncClient and InjectMock (mockk)
1 participant