Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add acm extension #1476

Merged
merged 4 commits into from
Nov 13, 2024
Merged

feat: add acm extension #1476

merged 4 commits into from
Nov 13, 2024

Conversation

emattheis
Copy link
Contributor

No description provided.

@emattheis emattheis requested a review from a team as a code owner November 12, 2024 00:44
scrocquesel
scrocquesel requested changes Nov 12, 2024
View reviewed changes
Copy link
Member

@scrocquesel scrocquesel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this contribution.

Could you replace importCertificate with requestCertificate. It should not change the expectation and will make the code cleaner. You could take the paramters from the localstack guide https://docs.localstack.cloud/user-guide/aws/acm/ keeping quarkus.local as the domain name.

@scrocquesel scrocquesel mentioned this pull request Nov 12, 2024
Closed
@emattheis
Copy link
Contributor Author

Could you replace importCertificate with requestCertificate. It should not change the expectation and will make the code cleaner. You could take the paramters from the localstack guide https://docs.localstack.cloud/user-guide/aws/acm/ keeping quarkus.local as the domain name.

Sure! I was focused on the use case that prompted me to create the extension, but I agree that requestCertificate would be much simpler 😂

@scrocquesel scrocquesel merged commit 59456bb into quarkiverse:main Nov 13, 2024
5 checks passed
@emattheis emattheis deleted the quarkus-amazon-acm branch November 13, 2024 20:09
scrocquesel pushed a commit to scrocquesel/quarkus-amazon-services that referenced this pull request Nov 17, 2024
@emattheis @scrocquesel
feat: add acm extension (quarkiverse#1476)
f1fcf4c 
* add new extension for ACM

* add documentation for ACM extension

* add ACM to list of services in README

* use requestCertificate to simplify tests and examples
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scrocquesel scrocquesel scrocquesel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emattheis @scrocquesel