Drop Python 3.9 support, require 3.10+ #353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following SPEC 0 Python 3.9 support is dropped for future minor and major releases, and will require Python 3.10+ from version 3.0 onwards. The main benefit of requiring Python 3.10 is that we can implement type hinting more elegant in the workbench. The 2.5.x branch will keep supporting Python 3.9.
|
looks fine to me. Just one quick question (which I can look up myself once I have time). What is the default python version on DelftBlue? |
|
Default 3.9, with 3.10 pre-installed. I think it will be updated around summer again. |
|
We can backport all MPI changes to the 2.5 branch to maintain full compatibility. |
|
Ok, let me try and finish the mpi bugfix branch first (testing atm), so I don't need to worry about 3.9/3.10. |
|
Can we merge this one? |
|
I was wondering the same thing, but yes LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following SPEC 0 Python 3.9 support is dropped for future minor and major releases, and will require Python 3.10+ from version 3.0 onwards.
The main benefit of requiring Python 3.10 is that we can implement type hinting more elegant in the workbench.
The 2.5.x branch will keep supporting Python 3.9.