-
Notifications
You must be signed in to change notification settings - Fork 385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduced BCS type Hamiltonians #770
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small nit but LGMT otherwise
from openfermion import (get_fermion_operator, InteractionOperator, \ | ||
normal_ordered) | ||
|
||
numpy.set_printoptions(linewidth=2000, threshold=sys.maxsize) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this can be remove right? Since the print statements are removed below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, these print options can be removed since they was used mostly for debugging purposes. However, print statements still exist in the test_fermionic_hamiltonian_from_integrals, and are also useful if the assert statements raise an error in the construction of an object of interest.
@cvmxn1 can I merge this? |
Yes, this branch is ready for merge, all docstrings and relevant information have been updated. |
* improved import formatting * support RichardsonGaudin-type Hamiltonians * improved formatting * corrected docstring which corresponds to the ladder operator Co-authored-by: Nicholas Rubin <[email protected]>
This PR aims to facilitate the use of reduced Bardeen-Cooper-Schrieffer Hamiltonians. Although these Hamiltonians are exactly solvable using the Richardson-Gaudin equations, are useful for serving as a benchmark for strongly correlated systems where the attractive regime is prominent and the equations break down, while maintaining a simple form, allowing for easier implementation in NISQ devices where the connectivity between qubits remains an important factor.
@ncrubin please share your thoughts and feedback on this.