Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduced BCS type Hamiltonians #770

Merged
merged 5 commits into from
Mar 1, 2022
Merged

Conversation

cvmxn1
Copy link
Contributor

@cvmxn1 cvmxn1 commented Feb 6, 2022

This PR aims to facilitate the use of reduced Bardeen-Cooper-Schrieffer Hamiltonians. Although these Hamiltonians are exactly solvable using the Richardson-Gaudin equations, are useful for serving as a benchmark for strongly correlated systems where the attractive regime is prominent and the equations break down, while maintaining a simple form, allowing for easier implementation in NISQ devices where the connectivity between qubits remains an important factor.

@ncrubin please share your thoughts and feedback on this.

ncrubin
ncrubin previously approved these changes Feb 7, 2022
Copy link
Collaborator

@ncrubin ncrubin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small nit but LGMT otherwise

from openfermion import (get_fermion_operator, InteractionOperator, \
normal_ordered)

numpy.set_printoptions(linewidth=2000, threshold=sys.maxsize)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this can be remove right? Since the print statements are removed below.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, these print options can be removed since they was used mostly for debugging purposes. However, print statements still exist in the test_fermionic_hamiltonian_from_integrals, and are also useful if the assert statements raise an error in the construction of an object of interest.

@ncrubin
Copy link
Collaborator

ncrubin commented Feb 27, 2022

@cvmxn1 can I merge this?

@cvmxn1
Copy link
Contributor Author

cvmxn1 commented Feb 28, 2022

Yes, this branch is ready for merge, all docstrings and relevant information have been updated.

@ncrubin ncrubin merged commit 3145a72 into quantumlib:master Mar 1, 2022
ncrubin added a commit to ncrubin/OpenFermion that referenced this pull request Jul 25, 2022
* improved import formatting

* support RichardsonGaudin-type Hamiltonians

* improved formatting

* corrected docstring which corresponds to the ladder operator

Co-authored-by: Nicholas Rubin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants