Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move scipy from runtime requirements to dev requirements #786

Closed
wants to merge 1 commit into from
Closed

Move scipy from runtime requirements to dev requirements #786

wants to merge 1 commit into from

Conversation

Strilanc
Copy link
Contributor

@Strilanc Strilanc commented Aug 1, 2018

  • It's only used in an example

@Strilanc Strilanc requested a review from maffoo August 1, 2018 01:36
@googlebot googlebot added the cla: yes Makes googlebot stop complaining. label Aug 1, 2018
@Strilanc
Copy link
Contributor Author

Strilanc commented Aug 1, 2018

Note: one of the downsides of doing this is that the tests won't pass unless you have the dev requirements. Maybe not such a good idea?

@cduck
Copy link
Collaborator

cduck commented Aug 1, 2018

But pytest is a dev requirement.

maffoo
maffoo approved these changes Aug 1, 2018
View reviewed changes
Copy link
Contributor

@maffoo maffoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dabacon
Copy link
Collaborator

dabacon commented Aug 1, 2018

One reason to keep scipy around would be for optimization algorithms.

@Strilanc
Copy link
Contributor Author

Strilanc commented Aug 1, 2018

Yes, it may become a dependency anyways soon enough.

Perhaps we should simply weaken the version requirement.

@Strilanc
Copy link
Contributor Author

Strilanc commented Aug 8, 2018

Obsoleted by #804 removing the version specifier on scipy

@Strilanc Strilanc closed this Aug 8, 2018
@Strilanc Strilanc deleted the move-req branch August 8, 2018 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maffoo maffoo maffoo approved these changes

Assignees
No one assigned
Labels
cla: yes Makes googlebot stop complaining.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Strilanc @cduck @dabacon @maffoo @googlebot