-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI - check for real if proto-derived files are up to date #6747
CI - check for real if proto-derived files are up to date #6747
Conversation
pavoljuhas
commented
Sep 27, 2024
- Rename check script build-changed-protos --> protos-up-to-date
- Excise unused code for getting base revision
- Exit with error status if dev_tools/build-protos.sh changes any content
- Fail the CI if generated protos are not up to date
Pick a name that says what does the script do.
Require that the script runs in a pristine worktree.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6747 +/- ##
=======================================
Coverage 97.83% 97.83%
=======================================
Files 1077 1077
Lines 92558 92558
=======================================
Hits 90555 90555
Misses 2003 2003 ☔ View full report in Codecov by Sentry. |
Executed dev_tools/build-protos.sh
This reverts commit 1b69f03.
Confirming that CI can now detect
Ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.