Start rewrites #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ns that don't use it
firstprivate() is exactly the same as private() but it will also set the variable to the original value at the start of the threads. This makes no sense for thread_num because it wasn't defined.
firstprivate() is exactly the same as private() but it will also set the variable to the original value at the start of the threads. This makes no sense for thread_num because it wasn't defined.
- w1 was only being written to but not being read -> stopped using it - firstprivate() is exactly the same as private() but it will also set the variable to the original value at the start of the threads. This makes no sense for thread_num because it wasn't defined.
firstprivate() is exactly the same as private() but it will also set the variable to the original value at the start of the threads. This makes no sense for thread_num because it wasn't defined.
- remove useless dirString; - w1 and w2 were only being written to but not being read -> stopped usage
The old method: - breaks if the program is name '-h' or similar - checks too many times if a argument is '-h' or similar - uses a less 'logical' way (e.g. working from back to front) The new method can also (these lines are commented at the moment): - Check if keys are given - Check if any args at all are given - Check and handle args that are given but don't belong to a key
- Rename outcol/outres to reasonable names - Define pi and calculate 1/(2*pi) instead of hardcoding (Calculations will be done at compiletime, so no loss in speed) - VERBOSE and DEBUG will be set to 1 if not defined so no there is no need to do a #ifdef for those
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pullreq include the changes of the prevous pullrequest (in case they are not merged yet)
At the moment this pullrequest rewrites a tiny part parse_input.cpp (the parsing of the commandline arguments is improved).
See the comments in the commit message for full info.
Until it's merged i might add other rewrites