Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supervision Configuration for Cluster Managers #450

Merged
merged 1 commit into from
Aug 18, 2020

Conversation

maennchen
Copy link
Member

Allows Implementation of #411

This allows new libraries that start quantum on its own terms. Even the central Supervisor can be overwritten to allow full control.

For better handling with restarts, implementations could also provide a default storage that provides ephemeral storage inside the cluster. This would keep the storage as long as not all nodes in the cluster are restarted at the same time.

@maennchen maennchen self-assigned this Aug 4, 2020
@maennchen
Copy link
Member Author

@coveralls
Copy link

coveralls commented Aug 4, 2020

Pull Request Test Coverage Report for Build a030dcf8c86b80411eea764de1eba6b0c9fb43c2-PR-450

  • 22 of 39 (56.41%) changed or added relevant lines in 9 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-4.3%) to 84.821%

Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/quantum/executor_supervisor.ex 1 3 33.33%
lib/quantum/clock_broadcaster.ex 1 4 25.0%
lib/quantum/execution_broadcaster.ex 1 4 25.0%
lib/quantum/job_broadcaster.ex 1 4 25.0%
lib/quantum/node_selector_broadcaster.ex 1 4 25.0%
lib/quantum/task_registry.ex 1 4 25.0%
Totals Coverage Status
Change from base Build a1ca7c42fe7be5cb2d4efce7cffd369f7dc0fa0b: -4.3%
Covered Lines: 285
Relevant Lines: 336

💛 - Coveralls

@maennchen maennchen force-pushed the supervision_configuration branch from 310da34 to 2df8b88 Compare August 18, 2020 09:32
@maennchen maennchen force-pushed the supervision_configuration branch from 2df8b88 to a030dcf Compare August 18, 2020 09:52
@maennchen maennchen marked this pull request as ready for review August 18, 2020 09:57
@maennchen maennchen merged commit d1d7a17 into master Aug 18, 2020
@maennchen maennchen deleted the supervision_configuration branch August 18, 2020 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants