Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Solution: Faster startup for non-global #383

Merged
merged 1 commit into from
Nov 22, 2018
Merged

Solution: Faster startup for non-global #383

merged 1 commit into from
Nov 22, 2018

Conversation

maennchen
Copy link
Member

Fix for #376

@maennchen maennchen added the bug label Nov 21, 2018
@maennchen maennchen requested a review from c-rack November 21, 2018 09:36
@coveralls
Copy link

Pull Request Test Coverage Report for Build 834

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • 5 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-1.07%) to 90.618%
Files with Coverage Reduction New Missed Lines %
lib/quantum/date_library/timex.ex 1 88.89%
lib/quantum/execution_broadcaster.ex 4 93.58%
Totals Coverage Status
Change from base Build 831: -1.07%
Covered Lines: 396
Relevant Lines: 437
💛 - Coveralls

@coveralls
Copy link

coveralls commented Nov 21, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 834

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • 5 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.2%) to 91.494%
Files with Coverage Reduction New Missed Lines %
lib/quantum/date_library/timex.ex 1 90.91%
lib/quantum/execution_broadcaster.ex 4 97.25%
Totals Coverage Status
Change from base Build 831: -0.2%
Covered Lines: 398
Relevant Lines: 435
💛 - Coveralls

@maennchen
Copy link
Member Author

The Build Error is not related to the PR, will create another PR with a fix in a few minutes.

@maennchen maennchen mentioned this pull request Nov 21, 2018
Merged
c-rack
c-rack approved these changes Nov 22, 2018
View reviewed changes
Copy link
Member

@c-rack c-rack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@c-rack c-rack merged commit 7c2fa0c into quantum-elixir:master Nov 22, 2018
@maennchen maennchen deleted the local_faster_startup branch June 18, 2019 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c-rack c-rack c-rack approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maennchen @coveralls @c-rack