Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to do custom actions #4

Merged
merged 1 commit into from
Jul 25, 2016
Merged

Conversation

GCorbel
Copy link
Contributor

@GCorbel GCorbel commented Jul 17, 2016

No description provided.

@eduardoweiland
Copy link
Contributor

Good work! 😄

Can you please split the custom action example from the index in the dummy app? Create a new route for "Custom actions". The Home example should be simpler and easy to understand, without too many customizations.

@@ -31,10 +38,19 @@ export default Controller.extend({
{
label: 'Country',
valuePath: 'country'
},
{
cellComponent: 'custom-actions'
Copy link
Contributor

@eduardoweiland eduardoweiland Jul 18, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add the option hideable: false so that this column does not appear on the column chooser menu, or add a label. Also, change this in the example snippet.

@GCorbel
Copy link
Contributor Author

GCorbel commented Jul 19, 2016

Done!

@GCorbel GCorbel force-pushed the master branch 2 times, most recently from 5a08bdc to 9658784 Compare July 19, 2016 21:59
@eduardoweiland
Copy link
Contributor

Please, revert the changes to tests/dummy/snippets/simple-table.js. The code for the tabs and collapse is used on the dummy app, but is not needed in the example snippets.
Also, use a component in the Custom Actions Example, as is already used in the other examples.

@GCorbel
Copy link
Contributor Author

GCorbel commented Jul 21, 2016

You're right. I did it. I found a little bit painful to maintain the snippets. Maybe there is a way to make it simpler. I know this is not really hard but, because it doesn't fail if there is something wrong, we have to be very careful.

@eduardoweiland eduardoweiland merged commit 67ae463 into quantosobra:master Jul 25, 2016
eduardoweiland added a commit that referenced this pull request Jul 25, 2016
Allow to do custom actions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants