-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: integrate treesitter to determine filetype at cursor position #50
Conversation
9c0a603
to
34d9836
Compare
34d9836
to
55443d0
Compare
55443d0
to
8a0f837
Compare
Just reviewed. thanks for the PR |
9cd51c5
to
ebd10c8
Compare
@quangnguyen30192 I just noticed we don't even need nvim-treesitter as a dependency. We can simply copy those functions from the nvim-treesitter plugin. Since Treesitter is built into Neovim we will always have the functionality we need. |
Cool 😊 |
4f067c5
to
742baa3
Compare
742baa3
to
cfb4c91
Compare
@quangnguyen30192 Please review again and test this feature :) E.g. in a CSS code block within a .html file. Also what do you think about adding a I don't think there will be noticeable performance issues right now because:
|
cfb4c91
to
25966b6
Compare
Just tested it and working fine 👍
Sure, let's go with it for now
Do we really need it as of now? Let's add it when the user needs it then. |
25966b6
to
9a03b07
Compare
9a03b07
to
4dad3d4
Compare
Heavily inspired by L3MON4D3/LuaSnip#226.
TODO:
filetype_source="both"
to show snippets for the current filetype as well as for the filetype determined by Treesitter? => we chose not to support it right now (if users actually want this feature, we will add it)filetype_source="treesitter"
option)