Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for ERiC 40 #7

Merged
merged 1 commit into from
Aug 6, 2024
Merged

feat: add support for ERiC 40 #7

merged 1 commit into from
Aug 6, 2024

Conversation

zembrowski
Copy link
Contributor

  • add bindings as of ERiC 40.1 (preprocessed with cpp)
  • make needed changes based on bindings

Side effect:

  • change ProcessingFlag to bitwise left shift numbers (as in header files)

quambene
quambene reviewed Aug 6, 2024
View reviewed changes
Copy link
Owner

@quambene quambene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice, some small comments and code needs to be formatted using cargo fmt to satisfy the CI pipeline

eric-sdk/CHANGELOG.md Show resolved Hide resolved
eric-bindings/src/bindings/mod.rs Show resolved Hide resolved
eric-bindings/src/lib.rs Show resolved Hide resolved
eric-bindings/CHANGELOG.md Show resolved Hide resolved
@quambene quambene merged commit 79771af into quambene:main Aug 6, 2024
5 of 7 checks passed
@zembrowski zembrowski deleted the feat-eric-40.2 branch August 9, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quambene quambene quambene left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zembrowski @quambene