Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small datetime fix #2249

Open
wants to merge 8 commits into
base: qa
Choose a base branch
from
Open

Small datetime fix #2249

wants to merge 8 commits into from

Conversation

luke-quadratic
Copy link
Contributor

Attempts to fix #2248 and adds tests for the case in the bug

@luke-quadratic luke-quadratic added the type: bug something is broken label Jan 30, 2025
Copy link

qa-wolf bot commented Jan 30, 2025

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

@cla-bot cla-bot bot added the cla-signed label Jan 30, 2025
Copy link
Contributor

github-actions bot commented Jan 30, 2025

Preview - Build & Deploy Images

✅ Build images
✅ Deploy images

🕒 Last deployed: Jan 30, 2025 at 09:55 PM UTC

🔗 URL: https://datetime-bug-fix.quadratic-preview.com

@github-actions github-actions bot temporarily deployed to preview-pr-2249 January 30, 2025 02:27 Destroyed
Copy link

codecov bot commented Jan 30, 2025

Codecov Report

Attention: Patch coverage is 86.47059% with 23 lines in your changes missing coverage. Please review.

Project coverage is 90.00%. Comparing base (026b02d) to head (40c6da7).

Files with missing lines Patch % Lines
quadratic-core/src/date_time.rs 85.88% 23 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##               qa    #2249      +/-   ##
==========================================
- Coverage   90.02%   90.00%   -0.03%     
==========================================
  Files         343      343              
  Lines       66758    66922     +164     
==========================================
+ Hits        60099    60230     +131     
- Misses       6659     6692      +33     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot temporarily deployed to preview-pr-2249 January 30, 2025 16:42 Destroyed
@github-actions github-actions bot temporarily deployed to preview-pr-2249 January 30, 2025 16:48 Destroyed
@github-actions github-actions bot temporarily deployed to preview-pr-2249 January 30, 2025 16:58 Destroyed
@github-actions github-actions bot temporarily deployed to preview-pr-2249 January 30, 2025 21:18 Destroyed
@github-actions github-actions bot temporarily deployed to preview-pr-2249 January 30, 2025 21:38 Destroyed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Date parsing for "Mon Year" doesn't work (Jan 2024)
1 participant