Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: delete LogRecordDiffIgnoreField, add properties diffIgnoreNullValue #77

Merged
merged 2 commits into from
Jul 24, 2023

Conversation

qqxx6661
Copy link
Owner

delete LogRecordDiffIgnoreField, use LogRecordDiffField properties instead. add properties diffIgnoreNullValue
add unit test
add docs

delete LogRecordDiffIgnoreField, use LogRecordDiffField properties instead.
add properties diffIgnoreNullValue
add unit test
add docs
@qqxx6661 qqxx6661 linked an issue Jul 19, 2023 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Jul 19, 2023

Codecov Report

Merging #77 (8b2db0d) into master (4e02fef) will increase coverage by 1.01%.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@             Coverage Diff              @@
##             master      #77      +/-   ##
============================================
+ Coverage     61.92%   62.94%   +1.01%     
- Complexity      134      147      +13     
============================================
  Files            19       19              
  Lines           612      618       +6     
  Branches         88       91       +3     
============================================
+ Hits            379      389      +10     
+ Misses          188      186       -2     
+ Partials         45       43       -2     
Flag Coverage Δ
unittests 62.94% <100.00%> (+1.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...l/logRecord/configuration/LogRecordProperties.java 25.00% <100.00%> (+4.41%) ⬆️
...l/logRecord/function/CustomFunctionObjectDiff.java 73.77% <100.00%> (+4.27%) ⬆️

@qqxx6661 qqxx6661 merged commit 62a358a into master Jul 24, 2023
@qqxx6661 qqxx6661 deleted the dev_diff_fix branch July 24, 2023 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

关于 Diff 根据内容忽略字段的建议
2 participants