Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crop #852

Merged
merged 23 commits into from
Jan 9, 2025
Merged

Fix crop #852

merged 23 commits into from
Jan 9, 2025

Conversation

zhangshanwen
Copy link
Contributor

No description provided.

Copy link

deepsource-io bot commented Jan 9, 2025

Here's the code health analysis summary for commits 28afd47..7f16fe1. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Test coverage LogoTest coverage✅ SuccessView Check ↗
DeepSource Go LogoGo✅ SuccessView Check ↗

Code Coverage Report

MetricAggregateGo
Composite Coverage41.9% (down 0.1% from main)41.9% (down 0.1% from main)
Line Coverage41.9% (down 0.1% from main)41.9% (down 0.1% from main)

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

Copy link

codecov bot commented Jan 9, 2025

Codecov Report

Attention: Patch coverage is 82.41758% with 64 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
media/base/handlers.go 27.27% 16 Missing and 8 partials ⚠️
media/cropper.go 16.66% 15 Missing ⚠️
media/base/base.go 42.85% 8 Missing ⚠️
media/filechooser.go 20.00% 3 Missing and 1 partial ⚠️
media/media_library/media_library.go 87.50% 3 Missing and 1 partial ⚠️
media/base/utils.go 50.00% 2 Missing and 1 partial ⚠️
media/media_library/media_box.go 80.00% 2 Missing and 1 partial ⚠️
pagebuilder/builder.go 93.18% 3 Missing ⚠️
Files with missing lines Coverage Δ
media/base/upload.go 76.92% <100.00%> (ø)
media/events.go 100.00% <ø> (ø)
media/media_box.go 85.73% <100.00%> (+3.81%) ⬆️
media/perm.go 100.00% <ø> (ø)
pagebuilder/editor.go 88.44% <100.00%> (+0.15%) ⬆️
pagebuilder/model.go 69.58% <100.00%> (+0.46%) ⬆️
pagebuilder/model_events.go 77.48% <100.00%> (+0.78%) ⬆️
publish/schedule_event.go 72.61% <100.00%> (ø)
media/base/utils.go 70.76% <50.00%> (-2.12%) ⬇️
media/media_library/media_box.go 69.23% <80.00%> (+4.11%) ⬆️
... and 6 more

@zhangshanwen zhangshanwen requested a review from molon January 9, 2025 02:26
@zhangshanwen zhangshanwen merged commit 21394e4 into main Jan 9, 2025
11 checks passed
@zhangshanwen zhangshanwen deleted the fix-crop branch January 9, 2025 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants