Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: style adjusting #588

Merged
merged 7 commits into from
Sep 23, 2024
Merged

style: style adjusting #588

merged 7 commits into from
Sep 23, 2024

Conversation

danni-cool
Copy link
Contributor

No description provided.

@danni-cool danni-cool requested a review from molon September 19, 2024 07:27
@deepsource-io deepsource.io
Copy link

deepsource-io bot commented Sep 19, 2024 •
edited
Loading

Here's the code health analysis summary for commits ef91d0c..33a383f. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Test coverage LogoTest coverage✅ SuccessView Check ↗
DeepSource Go LogoGo✅ SuccessView Check ↗

Code Coverage Report

MetricAggregateGo
Composite Coverage40.2%40.2%
Line Coverage40.2%40.2%
💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@codecov Codecov
Copy link

codecov bot commented Sep 19, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 64.44444% with 16 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
presets/presets.go 0.00% 9 Missing ⚠️
utils/confirm_dialog.go 75.86% 7 Missing ⚠️
Files with missing lines Coverage Δ
presets/detailing.go 63.65% <100.00%> (ø)
presets/field.go 82.91% <100.00%> (ø)
publish/version_compo.go 86.50% <100.00%> (+0.07%) ⬆️
utils/confirm_dialog.go 74.41% <75.86%> (+41.54%) ⬆️
presets/presets.go 75.49% <0.00%> (+2.61%) ⬆️

danni-cool and others added 3 commits September 20, 2024 20:36
@danni-cool
Merge branch 'main' into feat-ui-reborn
c772137
@danni-cool
pref: use vxDialog instead of vDialog in Utils.go
afd1510
@deepsource-autofix
style: format code with Gofumpt
b0d0dec 
This commit fixes the style issues introduced in afd1510 according to the output
from Gofumpt.

Details: #588
danni-cool and others added 3 commits September 23, 2024 11:23
@danni-cool
chore: update the version of x
0ab9aec
@danni-cool
test: add test of vxdialog and update the version of x
efd1aae
@deepsource-autofix
style: format code with Gofumpt
33a383f 
This commit fixes the style issues introduced in efd1aae according to the output
from Gofumpt.

Details: #588
@danni-cool danni-cool merged commit d2bde63 into main Sep 23, 2024
11 checks passed
@danni-cool danni-cool deleted the feat-ui-reborn branch September 23, 2024 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@molon molon molon approved these changes

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danni-cool @molon @theplant-ci