Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/campaign publish #275

Merged
merged 6 commits into from
Jun 21, 2024
Merged

Fix/campaign publish #275

merged 6 commits into from
Jun 21, 2024

Conversation

zhangshanwen
Copy link
Contributor

No description provided.

@codecov Codecov
Copy link

codecov bot commented Jun 19, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 70.58824% with 40 lines in your changes missing coverage. Please review.

Files Coverage Δ
publish/interfaces.go 73.91% <ø> (ø)
utils/utils.go 87.50% <100.00%> (+5.68%) ⬆️
...mples/examples_admin/page_builder_with_campaign.go 82.52% <88.88%> (+5.51%) ⬆️
pagebuilder/model.go 67.89% <85.71%> (+0.27%) ⬆️
pagebuilder/publish.go 27.27% <0.00%> (+16.74%) ⬆️
publish/builder.go 82.85% <70.78%> (-1.31%) ⬇️

... and 11 files with indirect coverage changes

sunfmin
sunfmin reviewed Jun 19, 2024
View reviewed changes
pagebuilder/publish.go Outdated

func (p *Page) LiveUrl(db *gorm.DB, ctx context.Context, storage oss.StorageInterface) (s string) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个方法一直返回空字符串？

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

忘记返回了

sunfmin
sunfmin approved these changes Jun 19, 2024
View reviewed changes
docs/docsrc/examples/examples_admin/page_builder_with_campaign.go Outdated
}

func (b *CampaignProduct) LiveUrl(db *gorm.DB, ctx context.Context, storage oss.StorageInterface) (s string) {
return "campaign-products/index.html"
Copy link
Contributor

@sunfmin sunfmin Jun 19, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个链接像是个列表页面？实际上是吗？

@zhangshanwen zhangshanwen merged commit 96be6a9 into main Jun 21, 2024
3 of 4 checks passed
@zhangshanwen zhangshanwen deleted the fix/campaign-publish branch June 21, 2024 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sunfmin sunfmin sunfmin approved these changes

@iBakuman iBakuman iBakuman approved these changes

Assignees
No one assigned
Labels
size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zhangshanwen @sunfmin @iBakuman @theplant-ci