Switch from chrono to time

.github/workflows/test.yml

@@ -2,6 +2,11 @@ name: test
 
 on: [push, pull_request]
 
+env:
+  # Minimum supported Rust version.
+  # Please also change README.md if you change this.
+  MSRV: 1.36.0
+
 jobs:
   test:
     runs-on: ubuntu-latest
@@ -12,9 +17,7 @@ jobs:
         - stable
         - beta
         - nightly
-        # Minimum supported Rust version.
-        # Please also change README.md if you change this.
-        - 1.36.0
+        - msrv
 
     env:
       RUSTFLAGS: -D warnings
@@ -23,14 +26,20 @@ jobs:
     - name: Install toolchain
       uses: actions-rs/toolchain@v1
       with:
-        toolchain: ${{ matrix.rust }}
+        toolchain: ${{ matrix.rust == 'msrv' && env.MSRV || matrix.rust }}
         override: true
     - name: Test
       run: |
         cargo build --verbose
         cargo test --verbose --no-default-features
-        cargo test --verbose --no-default-features --features="num-bigint bit-vec chrono std"
-        cargo doc --features="num-bigint bit-vec chrono"
+
+        # don't test features on MSRV
+        if [[ '${{ matrix.rust }}' != 'msrv' ]]; then
+          cargo test --verbose --no-default-features --features="num-bigint bit-vec time std"
+          cargo doc --features="num-bigint bit-vec time"
+        else
+          cargo doc
+        fi
       continue-on-error: ${{ matrix.rust == 'nightly' }}
     - name: Deploy to GitHub Pages
       uses: peaceiris/actions-gh-pages@v3

Cargo.toml

@@ -21,7 +21,7 @@ default = []
 std = []
 
 [package.metadata.docs.rs]
-features = ["num-bigint", "bit-vec", "chrono", "std"]
+features = ["num-bigint", "bit-vec", "time", "std"]
 
 [dependencies]
 
@@ -39,8 +39,8 @@ default-features = false
 features = ["std"]
 optional = true
 
-[dependencies.chrono]
-version = "0.4"
+[dependencies.time]
+version = "0.3"
 optional = true
 default-features = false
 features = ["std"]

README.md

@@ -86,6 +86,7 @@ This library is currently specialized for on-memory serialization/deserializatio
 ## Compatibility
 
 The minimum supported Rust version (MSRV) of `yasna.rs` is Rust 1.36.0.
+Optional feature flags that enable interoperability with third-party crates (e.g. `time`) follow the policy of that crate if stricter.
 
 ## License
 

src/deserializer/mod.rs

@@ -18,7 +18,7 @@ use bit_vec::BitVec;
 
 use super::{ASN1Result,BERMode,BERReader,parse_ber_general};
 use super::models::{ObjectIdentifier,TaggedDerValue};
-#[cfg(feature = "chrono")]
+#[cfg(feature = "time")]
 use super::models::{UTCTime,GeneralizedTime};
 
 /// Types decodable in BER.
@@ -233,14 +233,14 @@ impl BERDecodable for ObjectIdentifier {
     }
 }
 
-#[cfg(feature = "chrono")]
+#[cfg(feature = "time")]
 impl BERDecodable for UTCTime {
     fn decode_ber(reader: BERReader) -> ASN1Result<Self> {
         reader.read_utctime()
     }
 }
 
-#[cfg(feature = "chrono")]
+#[cfg(feature = "time")]
 impl BERDecodable for GeneralizedTime {
     fn decode_ber(reader: BERReader) -> ASN1Result<Self> {
         reader.read_generalized_time()

src/models/mod.rs

@@ -11,11 +11,11 @@
 #![forbid(missing_docs)]
 
 mod oid;
-#[cfg(feature = "chrono")]
+#[cfg(feature = "time")]
 mod time;
 mod der;
 
 pub use self::oid::{ObjectIdentifier, ParseOidError};
-#[cfg(feature = "chrono")]
+#[cfg(feature = "time")]
 pub use self::time::{UTCTime,GeneralizedTime};
 pub use self::der::TaggedDerValue;