Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#define AUTO_SHIFT_SETUP #8441

Merged
merged 3 commits into from
Aug 15, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/feature_auto_shift.md
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ completely normal and with no intention of shifted keys.
`KC_ASRP`. The keyboard will type by itself the value of your
`AUTO_SHIFT_TIMEOUT`.
7. Update `AUTO_SHIFT_TIMEOUT` in your `config.h` with the value reported.
8. Remove `AUTO_SHIFT_SETUP` from your `config.h`.
8. Add `AUTO_SHIFT_NO_SETUP` to your `config.h`.
9. Remove the key bindings `KC_ASDN`, `KC_ASUP` and `KC_ASRP`.
10. Compile and upload your new firmware.

Expand Down
70 changes: 37 additions & 33 deletions quantum/process_keycode/process_auto_shift.c
Original file line number Diff line number Diff line change
Expand Up @@ -25,19 +25,6 @@ static uint16_t autoshift_time = 0;
static uint16_t autoshift_timeout = AUTO_SHIFT_TIMEOUT;
static uint16_t autoshift_lastkey = KC_NO;

void autoshift_timer_report(void) {
char display[8];

snprintf(display, 8, "\n%d\n", autoshift_timeout);

send_string((const char *)display);
}

void autoshift_on(uint16_t keycode) {
autoshift_time = timer_read();
autoshift_lastkey = keycode;
}

void autoshift_flush(void) {
if (autoshift_lastkey != KC_NO) {
uint16_t elapsed = timer_elapsed(autoshift_time);
Expand All @@ -53,21 +40,36 @@ void autoshift_flush(void) {
}
}

void autoshift_enable(void) { autoshift_enabled = true; }
void autoshift_disable(void) {
void autoshift_on(uint16_t keycode) {
autoshift_time = timer_read();
autoshift_lastkey = keycode;
}

void autoshift_toggle(void) {
if (autoshift_enabled) {
autoshift_enabled = false;
autoshift_flush();
} else {
autoshift_enabled = true;
}
}

void autoshift_toggle(void) {
if (autoshift_enabled) {
autoshift_enabled = false;
autoshift_flush();
} else {
autoshift_enabled = true;
}
void autoshift_enable(void) { autoshift_enabled = true; }
void autoshift_disable(void) {
autoshift_enabled = false;
autoshift_flush();
}

#ifndef AUTO_SHIFT_NO_SETUP
void autoshift_timer_report(void) {
char display[8];

snprintf(display, 8, "\n%d\n", autoshift_timeout);

send_string((const char *)display);
}
#endif

bool get_autoshift_state(void) { return autoshift_enabled; }

uint16_t get_autoshift_timeout(void) { return autoshift_timeout; }
Expand All @@ -77,28 +79,30 @@ void set_autoshift_timeout(uint16_t timeout) { autoshift_timeout = timeout; }
bool process_auto_shift(uint16_t keycode, keyrecord_t *record) {
if (record->event.pressed) {
switch (keycode) {
case KC_ASUP:
autoshift_timeout += 5;
return true;

case KC_ASDN:
autoshift_timeout -= 5;
return true;

case KC_ASRP:
autoshift_timer_report();
return true;

case KC_ASTG:
autoshift_toggle();
return true;

case KC_ASON:
autoshift_enable();
return true;
case KC_ASOFF:
autoshift_disable();
return true;

# ifndef AUTO_SHIFT_NO_SETUP
case KC_ASUP:
autoshift_timeout += 5;
return true;
case KC_ASDN:
autoshift_timeout -= 5;
return true;

case KC_ASRP:
autoshift_timer_report();
return true;
# endif
# ifndef NO_AUTO_SHIFT_ALPHA
case KC_A ... KC_Z:
# endif
Expand Down
4 changes: 3 additions & 1 deletion quantum/quantum_keycodes.h
Original file line number Diff line number Diff line change
Expand Up @@ -123,10 +123,12 @@ enum quantum_keycodes {
KC_LEAD,
#endif

// Auto Shift setup
// Auto Shift setup
#ifndef AUTO_SHIFT_NO_SETUP
KC_ASUP,
KC_ASDN,
KC_ASRP,
#endif
KC_ASTG,
KC_ASON,
KC_ASOFF,
Expand Down