Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to nano specs on ChibiOS builds #8270

Merged
merged 1 commit into from
Mar 1, 2020
Merged

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Feb 29, 2020

Description

Saves a little extra space (about 1~2k with the limited testing I've done so far) to avoid the impact of #8269.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr requested a review from a team February 29, 2020 10:50
@tzarc
Copy link
Member

tzarc commented Feb 29, 2020

In principle approval for nano specs, I'll assume the rest of the changes will be missing once #8268 goes in. Will wait for that then approve.

@zvecr zvecr force-pushed the feature/nanospecs branch from 3b4d1c5 to c68ef30 Compare February 29, 2020 23:31
@zvecr zvecr marked this pull request as ready for review February 29, 2020 23:31
@drashna drashna requested a review from a team March 1, 2020 00:10
@tzarc tzarc merged commit c775104 into qmk:master Mar 1, 2020
cmaier pushed a commit to cmaier/qmk_firmware that referenced this pull request Mar 1, 2020
rhruiz pushed a commit to rhruiz/qmk_firmware that referenced this pull request Mar 1, 2020
HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Mar 5, 2020
c0psrul3 pushed a commit to c0psrul3/qmk_firmware that referenced this pull request Mar 23, 2020
sowbug pushed a commit to sowbug/qmk_firmware that referenced this pull request Apr 2, 2020
kylekuj pushed a commit to kylekuj/qmk_firmware that referenced this pull request Apr 21, 2020
@zvecr zvecr deleted the feature/nanospecs branch April 28, 2020 01:14
zvecr added a commit that referenced this pull request May 8, 2020
zvecr added a commit that referenced this pull request May 8, 2020
bitherder pushed a commit to bitherder/qmk_firmware that referenced this pull request May 15, 2020
drashna pushed a commit to zsa/qmk_firmware that referenced this pull request May 24, 2020
sowbug pushed a commit to sowbug/qmk_firmware that referenced this pull request May 24, 2020
turky pushed a commit to turky/qmk_firmware that referenced this pull request Jun 13, 2020
jakobaa pushed a commit to jakobaa/qmk_firmware that referenced this pull request Jul 7, 2020
jakeisnt pushed a commit to jakeisnt/qmk_firmware that referenced this pull request Aug 20, 2020
sjmacneil pushed a commit to sjmacneil/qmk_firmware that referenced this pull request Feb 19, 2021
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants