Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in uart.c backport and add 32A "support" #8219

Merged
merged 1 commit into from
Mar 6, 2020
Merged

Fix typo in uart.c backport and add 32A "support" #8219

merged 1 commit into from
Mar 6, 2020

Conversation

fauxpark
Copy link
Member

@fauxpark fauxpark commented Feb 21, 2020 •
edited by zvecr
Loading

Description

Slight correction to #7628 (UCSRB -> UCSRnB and UDR0 -> UDRn), and adding the 32A to the defines (untested) The 32A is a bit odd as the high byte of the baud rate register UBRR shares the same memory location as the control/status register C (UCSRC). The MSB URSEL is used to choose between them. I'm doubtful those top three bits are really used so I just switched the define to use the low byte.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark requested a review from a team February 21, 2020 12:35
@drashna drashna requested a review from a team February 23, 2020 21:46
tzarc
tzarc approved these changes Mar 1, 2020
View reviewed changes
Copy link
Member

@tzarc tzarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine when targeting coseyfannitutti/mysterium.

@zvecr
Copy link
Member

zvecr commented Mar 1, 2020

@tzarc coseyfannitutti/mysterium doesnt build tmk_core/common/uart.c? Or is there a scenario I have missed?

@fauxpark
Copy link
Member Author

fauxpark commented Mar 1, 2020

Only the iWRAP and V-USB makefiles reference uart.c - but if you try setting NO_UART = no in the rules.mk (+ remove the redundant NO_UART 1 define in config.h) odDebug.c spits out a warning which fails the build:

Never compile production devices with debugging enabled

@zvecr
Copy link
Member

zvecr commented Mar 1, 2020

My point was more "if it's not in the list of compiled files, have we really tested it on the 32a in the mysterium"?

@fauxpark
Copy link
Member Author

fauxpark commented Mar 1, 2020

And my point was "no, we have not" 😄

@tzarc
Copy link
Member

tzarc commented Mar 1, 2020

Oh for sure, there's no need for uart on this board.
Really, all we can glean is that it didn't break existing 32A's that don't use uart.c -- I don't have a device that does.

@drashna drashna requested a review from a team March 4, 2020 10:04
@fauxpark fauxpark merged commit 9810756 into qmk:master Mar 6, 2020
@fauxpark fauxpark deleted the uart-32a branch March 6, 2020 12:55
c0psrul3 pushed a commit to c0psrul3/qmk_firmware that referenced this pull request Mar 23, 2020
@fauxpark @c0psrul3
Fix typo in uart.c backport and add 32A "support" (qmk#8219)
1b3a975
sowbug pushed a commit to sowbug/qmk_firmware that referenced this pull request Apr 2, 2020
@fauxpark @sowbug
Fix typo in uart.c backport and add 32A "support" (qmk#8219)
97f890a
HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Apr 10, 2020
@fauxpark @HokieGeek
Fix typo in uart.c backport and add 32A "support" (qmk#8219)
6f505ab
kylekuj pushed a commit to kylekuj/qmk_firmware that referenced this pull request Apr 21, 2020
@fauxpark @kujawakk
Fix typo in uart.c backport and add 32A "support" (qmk#8219)
95763c8
drashna pushed a commit to zsa/qmk_firmware that referenced this pull request May 24, 2020
@fauxpark @drashna
Fix typo in uart.c backport and add 32A "support" (qmk#8219)
4d704fb
drashna pushed a commit to zsa/qmk_firmware that referenced this pull request May 24, 2020
@fauxpark @drashna
Fix typo in uart.c backport and add 32A "support" (qmk#8219)
f0407dd
fdidron pushed a commit to zsa/qmk_firmware that referenced this pull request Jun 12, 2020
@fauxpark @fdidron
Fix typo in uart.c backport and add 32A "support" (qmk#8219)
ead0015
jakobaa pushed a commit to jakobaa/qmk_firmware that referenced this pull request Jul 7, 2020
@fauxpark @jakobaa
Fix typo in uart.c backport and add 32A "support" (qmk#8219)
73f4243
jakeisnt pushed a commit to jakeisnt/qmk_firmware that referenced this pull request Aug 20, 2020
@fauxpark @jakeisnt
Fix typo in uart.c backport and add 32A "support" (qmk#8219)
f393250
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
@fauxpark
Fix typo in uart.c backport and add 32A "support" (qmk#8219)
67e3760
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@tzarc tzarc tzarc approved these changes

Assignees
No one assigned
Labels
bug core enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fauxpark @zvecr @tzarc @drashna