Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DevastatingTKL Keyboard #8209

Merged
merged 10 commits into from
Apr 11, 2020
Merged

DevastatingTKL Keyboard #8209

merged 10 commits into from
Apr 11, 2020

Conversation

awkannan
Copy link
Contributor

@awkannan awkannan commented Feb 20, 2020 •
edited
Loading

Description

Adding the new DevastatingTKL keyboard

TODO:

  • Test on hardware

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@drashna drashna requested a review from a team February 21, 2020 01:59
fauxpark
fauxpark requested changes Feb 21, 2020
View reviewed changes
keyboards/cannonkeys/devastatingTKL/readme.md Outdated Show resolved Hide resolved
keyboards/cannonkeys/devastatingTKL/readme.md Outdated Show resolved Hide resolved
keyboards/cannonkeys/devastatingTKL/rules.mk Outdated Show resolved Hide resolved
keyboards/cannonkeys/devastatingTKL/rules.mk Outdated Show resolved Hide resolved
keyboards/cannonkeys/devastatingTKL/rules.mk Outdated Show resolved Hide resolved
@awkannan awkannan marked this pull request as ready for review February 21, 2020 15:29
@awkannan
Copy link
Contributor Author

@noroadsleft @zvecr @fauxpark Addressed all PR comments

@noroadsleft noroadsleft requested a review from tzarc March 3, 2020 09:40
drashna
drashna reviewed Mar 4, 2020
View reviewed changes
keyboards/cannonkeys/devastatingtkl/keymaps/via/keymap.c
KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS,
KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS),

};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC, this need to have all 4 layers explicitly set

zvecr
zvecr requested changes Mar 4, 2020
View reviewed changes
Copy link
Member

@zvecr zvecr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this still has the old chibios conf files, and will break once merged or rebased.

@drashna drashna requested a review from a team March 6, 2020 23:58
@awkannan awkannan force-pushed the 202002_devastating_tkl branch from f908a0e to e3835e3 Compare April 7, 2020 02:34
@awkannan
Copy link
Contributor Author

awkannan commented Apr 7, 2020

@zvecr @noroadsleft @fauxpark this one is also ready again

noroadsleft
noroadsleft approved these changes Apr 9, 2020
View reviewed changes
Copy link
Member

@noroadsleft noroadsleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@noroadsleft noroadsleft requested a review from zvecr April 9, 2020 02:06
@awkannan
Copy link
Contributor Author

@zvecr Bump on this one

@zvecr zvecr merged commit dfdc892 into qmk:master Apr 11, 2020
@zvecr
Copy link
Member

zvecr commented Apr 11, 2020

Thanks!

@zvecr zvecr mentioned this pull request Apr 11, 2020
Merged
13 tasks
violet-fish pushed a commit to violet-fish/qmk_firmware that referenced this pull request Apr 12, 2020
@fauxpark @noroadsleft
@zvecr @violet-fish
DevastatingTKL Keyboard (qmk#8209)
0176aff 
* Save progress

* Finished matrix and everything

* Apply suggestions from code review

Co-Authored-By: Ryan <[email protected]>

* Update DevastatingTKL

* Renames

* Add renamed files

* Update chibios files and VIA keymap for completion

* Some cleanup

* Apply suggestions from code review

Co-Authored-By: James Young <[email protected]>

* Update keyboards/cannonkeys/devastatingtkl/rules.mk

Co-Authored-By: Joel Challis <[email protected]>

Co-authored-by: Ryan <[email protected]>
Co-authored-by: James Young <[email protected]>
Co-authored-by: Joel Challis <[email protected]>
Quarren42 pushed a commit to Quarren42/qmk_firmware that referenced this pull request Apr 15, 2020
@fauxpark @noroadsleft
@zvecr @Quarren42
DevastatingTKL Keyboard (qmk#8209)
1ceba11 
* Save progress

* Finished matrix and everything

* Apply suggestions from code review

Co-Authored-By: Ryan <[email protected]>

* Update DevastatingTKL

* Renames

* Add renamed files

* Update chibios files and VIA keymap for completion

* Some cleanup

* Apply suggestions from code review

Co-Authored-By: James Young <[email protected]>

* Update keyboards/cannonkeys/devastatingtkl/rules.mk

Co-Authored-By: Joel Challis <[email protected]>

Co-authored-by: Ryan <[email protected]>
Co-authored-by: James Young <[email protected]>
Co-authored-by: Joel Challis <[email protected]>
kylekuj pushed a commit to kylekuj/qmk_firmware that referenced this pull request Apr 21, 2020
@fauxpark @noroadsleft
@zvecr @kujawakk
DevastatingTKL Keyboard (qmk#8209)
3e422a6 
* Save progress

* Finished matrix and everything

* Apply suggestions from code review

Co-Authored-By: Ryan <[email protected]>

* Update DevastatingTKL

* Renames

* Add renamed files

* Update chibios files and VIA keymap for completion

* Some cleanup

* Apply suggestions from code review

Co-Authored-By: James Young <[email protected]>

* Update keyboards/cannonkeys/devastatingtkl/rules.mk

Co-Authored-By: Joel Challis <[email protected]>

Co-authored-by: Ryan <[email protected]>
Co-authored-by: James Young <[email protected]>
Co-authored-by: Joel Challis <[email protected]>
bitherder pushed a commit to bitherder/qmk_firmware that referenced this pull request May 15, 2020
@fauxpark @noroadsleft
@zvecr @lorenzoernesto
DevastatingTKL Keyboard (qmk#8209)
abccf36 
* Save progress

* Finished matrix and everything

* Apply suggestions from code review

Co-Authored-By: Ryan <[email protected]>

* Update DevastatingTKL

* Renames

* Add renamed files

* Update chibios files and VIA keymap for completion

* Some cleanup

* Apply suggestions from code review

Co-Authored-By: James Young <[email protected]>

* Update keyboards/cannonkeys/devastatingtkl/rules.mk

Co-Authored-By: Joel Challis <[email protected]>

Co-authored-by: Ryan <[email protected]>
Co-authored-by: James Young <[email protected]>
Co-authored-by: Joel Challis <[email protected]>
sowbug pushed a commit to sowbug/qmk_firmware that referenced this pull request May 24, 2020
@fauxpark @noroadsleft
@zvecr @sowbug
DevastatingTKL Keyboard (qmk#8209)
32b7f7a 
* Save progress

* Finished matrix and everything

* Apply suggestions from code review

Co-Authored-By: Ryan <[email protected]>

* Update DevastatingTKL

* Renames

* Add renamed files

* Update chibios files and VIA keymap for completion

* Some cleanup

* Apply suggestions from code review

Co-Authored-By: James Young <[email protected]>

* Update keyboards/cannonkeys/devastatingtkl/rules.mk

Co-Authored-By: Joel Challis <[email protected]>

Co-authored-by: Ryan <[email protected]>
Co-authored-by: James Young <[email protected]>
Co-authored-by: Joel Challis <[email protected]>
turky pushed a commit to turky/qmk_firmware that referenced this pull request Jun 13, 2020
@fauxpark @noroadsleft
@zvecr @turky
DevastatingTKL Keyboard (qmk#8209)
8a15b50 
* Save progress

* Finished matrix and everything

* Apply suggestions from code review

Co-Authored-By: Ryan <[email protected]>

* Update DevastatingTKL

* Renames

* Add renamed files

* Update chibios files and VIA keymap for completion

* Some cleanup

* Apply suggestions from code review

Co-Authored-By: James Young <[email protected]>

* Update keyboards/cannonkeys/devastatingtkl/rules.mk

Co-Authored-By: Joel Challis <[email protected]>

Co-authored-by: Ryan <[email protected]>
Co-authored-by: James Young <[email protected]>
Co-authored-by: Joel Challis <[email protected]>
jakobaa pushed a commit to jakobaa/qmk_firmware that referenced this pull request Jul 7, 2020
@fauxpark @noroadsleft
@zvecr @jakobaa
DevastatingTKL Keyboard (qmk#8209)
ed0d33d 
* Save progress

* Finished matrix and everything

* Apply suggestions from code review

Co-Authored-By: Ryan <[email protected]>

* Update DevastatingTKL

* Renames

* Add renamed files

* Update chibios files and VIA keymap for completion

* Some cleanup

* Apply suggestions from code review

Co-Authored-By: James Young <[email protected]>

* Update keyboards/cannonkeys/devastatingtkl/rules.mk

Co-Authored-By: Joel Challis <[email protected]>

Co-authored-by: Ryan <[email protected]>
Co-authored-by: James Young <[email protected]>
Co-authored-by: Joel Challis <[email protected]>
thorstenweber83 pushed a commit to thorstenweber83/qmk_firmware that referenced this pull request Sep 2, 2020
@fauxpark @noroadsleft
@zvecr @thorstenweber83
DevastatingTKL Keyboard (qmk#8209)
ccc3634 
* Save progress

* Finished matrix and everything

* Apply suggestions from code review

Co-Authored-By: Ryan <[email protected]>

* Update DevastatingTKL

* Renames

* Add renamed files

* Update chibios files and VIA keymap for completion

* Some cleanup

* Apply suggestions from code review

Co-Authored-By: James Young <[email protected]>

* Update keyboards/cannonkeys/devastatingtkl/rules.mk

Co-Authored-By: Joel Challis <[email protected]>

Co-authored-by: Ryan <[email protected]>
Co-authored-by: James Young <[email protected]>
Co-authored-by: Joel Challis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@fauxpark fauxpark fauxpark approved these changes

@zvecr zvecr zvecr approved these changes

@noroadsleft noroadsleft noroadsleft approved these changes

@tzarc tzarc Awaiting requested review from tzarc

Assignees
No one assigned
Labels
keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@awkannan @zvecr @drashna @fauxpark @noroadsleft