fix: Make escape work after changing the backlight settings on the HS60 V2

[Hornwall]

Description

This pull request fixes a bug where the keymap for the the top left key (usually escape) would be overwritten by the config for the rgb-backlight when it was written to the EEPROM. This would render the key unusable as the first byte of the keymap seems to be overwritten with the last byte of the backlight config. This is fixed by offsetting the keymap and everything there after by moving it by one byte

Steps to reproduce

1. Flash the current version of HS60 V2 ANSI to the board make hs60/v2:ansi:dfu-util
2. The escape key should be working as expected
3. Change backlight effect/hue/brightness
4. The escape key will no longer be responsive, layer 2+ and the escape key still works fine.
5. Reset the EEPROM Unplug -> Hold escape -> Plug in -> Unplug -> Release escape -> Plug in
6. The escape key should now be functional until you change the backlight settings again.

My friend tested the current version on the ISO version of this PCB and the issue does not seem to be present on that version. He also tested this branch and it did not break anything for him.

Types of Changes

• Core
• Bugfix
• New feature
• Enhancement/optimization
• Keyboard (addition or update)
• Keymap/layout/userspace (addition or update)
• Documentation

Checklist

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• I have tested the changes and verified that they work and don't break anything (as well as I can manage).

[drashna]

@yiancar ?

[yiancar]

Yes this is correct!

[drashna]

Awesome, just wanted to make sure!

[yiancar]

Yep thank you! Thanks @Hornwall for figuring this out

[Hornwall]

Happy to help! Thank you for the quick response!

[drashna]

there are a few of us that check PRs often. :)

And we're glad to see people help out! It's a huge part of what makes QMK awesome!

[andys8]

@yiancar I had issues today, where the keyboard was not working at all after flashing QMK. Can this change be related?

My solution was to rebase to the initial commit that added hs60v2, enable Bootmagic in the config, delete the eeprom with space + backspace, and it worked afterwards.

Escape was not working at all (this PR is/was not applied). I disabled backlighting and ESC is working.

But regarding this PR and the current state of master: Is it working? And is the flash with dfu-util working with initial firmware, or could the EEPROM change mess things up? If it's necessary to reset the EEPROM, we could add it to the README :)

Update

I tested, if it's only relying on previously stored EEPROM data, resulting in weird behavior. And it looks like that's the case. With the instructions above, one can delete the EEPROM and this branch is working fine. But if somebody doesn't and/or isn't aware of having to do it, this could be an issue.

[yiancar]

Yes the update goes hand in hand with an EEPROM clear. If you follow the instructions that came with the pcb, it asks to put the pcb in bootloader mode by holding down the ESC key while plugging in the usb. This also resets the EEPROM.

[andys8]

Thanks for the reply. Are the instructions available online? I don't have any (could have thrown them away by a accident).

[yiancar]

https://mechboards.co.uk/info-hs60/ :)

[andys8]

Whoa, awesome.

Mechboards could add a link to it on the product page. I'll ask them via email.

Can we add the reset instructions to the readme file? I'll create a small PR.

[yiancar]

Sure feel free to add the instructions on the readme:)

[andys8]

#5241