Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundant KC_TRNS and KC_NO fillers in remaining keymaps #5154

Merged
merged 1 commit into from
Feb 17, 2019
Merged

Remove redundant KC_TRNS and KC_NO fillers in remaining keymaps #5154

merged 1 commit into from
Feb 17, 2019

Conversation

fauxpark
Copy link
Member

Description

The thrilling conclusion!

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

mechmerlin
mechmerlin approved these changes Feb 17, 2019
View reviewed changes
Copy link
Contributor

@mechmerlin mechmerlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing all the copy pasta.

@mechmerlin mechmerlin merged commit 3b2a484 into qmk:master Feb 17, 2019
@fauxpark fauxpark deleted the remove-fillers-remaining-keymaps branch February 17, 2019 21:46
zer09 pushed a commit to zer09/qmk_firmware that referenced this pull request Mar 2, 2019
@fauxpark @zer09
Remove redundant KC_TRNS and KC_NO fillers in remaining keymaps (qmk#…
db5f75b 
…5154)
dlhextall pushed a commit to dlhextall/qmk_firmware that referenced this pull request May 24, 2019
@fauxpark
Remove redundant KC_TRNS and KC_NO fillers in remaining keymaps (qmk#…
df26598 
…5154)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mechmerlin mechmerlin mechmerlin approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fauxpark @mechmerlin