Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundant KC_TRNS and KC_NO fillers in layouts #5142

Merged
merged 1 commit into from
Feb 16, 2019
Merged

Remove redundant KC_TRNS and KC_NO fillers in layouts #5142

merged 1 commit into from
Feb 16, 2019

Conversation

fauxpark
Copy link
Member

Description

...

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

vomindoraan
vomindoraan approved these changes Feb 16, 2019
View reviewed changes
Copy link
Contributor

@vomindoraan vomindoraan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this all of them? I imagined there were more. In any case, LGTM!

@fauxpark
Copy link
Member Author

All of them in layouts/ ;)

grep

@vomindoraan
Copy link
Contributor

Ohh right, I missed that part of the title! I'm assuming that cleaning up the occurrences in keyboards/ will be your next PR? 😉

@fauxpark
Copy link
Member Author

Just the ones in the default keymaps first, then the rest. And then back to fn_actions!

mechmerlin
mechmerlin approved these changes Feb 16, 2019
View reviewed changes
Copy link
Contributor

@mechmerlin mechmerlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mechmerlin mechmerlin merged commit bbd4b5e into qmk:master Feb 16, 2019
@fauxpark fauxpark deleted the remove-fillers-layouts branch February 16, 2019 23:09
dlhextall pushed a commit to dlhextall/qmk_firmware that referenced this pull request May 24, 2019
@fauxpark
Remove redundant KC_TRNS and KC_NO fillers in layouts (qmk#5142)
6f21650
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vomindoraan vomindoraan vomindoraan approved these changes

@mechmerlin mechmerlin mechmerlin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fauxpark @vomindoraan @mechmerlin