Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Namecard rev2 #5080

Merged
merged 4 commits into from
Feb 10, 2019
Merged

Namecard rev2 #5080

merged 4 commits into from
Feb 10, 2019

Conversation

takashiski
Copy link
Contributor

@takashiski takashiski commented Feb 8, 2019

Description

I add namecard2x4 rev2 and create rev1(move config.h and rule.mk).

Types of changes

  • Core
  • Bugfix
  • New Feature
  • Enhancement/Optimization
  • Keyboard (addition or update)
  • Keymap/Layout/Userspace (addition or update)
  • Documentation

Issues Fixed or Closed by this PR

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document. (https://docs.qmk.fm/#/contributing)
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@drashna
Copy link
Member

drashna commented Feb 10, 2019

Thanks!

@drashna drashna merged commit 6848002 into qmk:master Feb 10, 2019
Shinichi-Ohki added a commit to Shinichi-Ohki/qmk_firmware that referenced this pull request Feb 11, 2019
* 'master' of https://github.com/qmk/qmk_firmware:
  fix the led_matrix.h naming conflict
  Put back an accidentally stripped copyright
  cleanup
  fix compiling for backlight without led matrix
  cleanup
  Move the 1 second delay to led_matrix_init
  Add documentation for led matrix
  Force backlight on when led matrix is enabled
  led_matrix works now
  compiles, but long delay on startup and problems
  revert accidental rgb_matrix.h changes
  The beginning of a simple led matrix driver for is31fl3731
  [Keymap] Added my THE50 Keymap (qmk#5093)
  [Keyboard] Update ergodash readme.md (qmk#5092)
  [Keyboard] Initial support for TKC M0LLY (qmk#5087)
  [Keyboard] Namecard rev2 (qmk#5080)
  added missing ; on example (qmk#5089)
@takashiski takashiski deleted the namecardR2 branch March 3, 2019 02:49
dlhextall pushed a commit to dlhextall/qmk_firmware that referenced this pull request May 24, 2019
* add revision

* change to row2col

* remove old config.h

* remove rule.mk from namecard2x4/
mjbcopland pushed a commit to mjbcopland/qmk_firmware that referenced this pull request Sep 26, 2019
* add revision

* change to row2col

* remove old config.h

* remove rule.mk from namecard2x4/
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants