Add another secure string emitter to the keymap #5057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mechmerlin
reviewed
Feb 5, 2019
Co-Authored-By: rys <[email protected]>
zer09
pushed a commit
to zer09/qmk_firmware
that referenced
this pull request
Feb 16, 2019
* Add another secure string emitter to the keymap * Delete BACKLIGHT_ENABLE since it's default Co-Authored-By: rys <[email protected]>
dlhextall
pushed a commit
to dlhextall/qmk_firmware
that referenced
this pull request
May 24, 2019
* Add another secure string emitter to the keymap * Delete BACKLIGHT_ENABLE since it's default Co-Authored-By: rys <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for fetching another securely stored string from the macOS keychain, to emit in the firmware.
Description
Fetch another secure string in
rules.mkusing thesecuritybinary on macOS, and emit that with a new keycode in the safe range.Fixes a tiny alignment foible in the makefile rules too. OCD.
I also wrote about the basic process and the threat model on my blog, here!
Types of changes
Issues Fixed or Closed by this PR
N/A
Checklist: