Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TMO50 Off By 1 Column Bug #5055

Merged
merged 4 commits into from
Feb 5, 2019
Merged

TMO50 Off By 1 Column Bug #5055

merged 4 commits into from
Feb 5, 2019

Conversation

mechmerlin
Copy link
Contributor

@mechmerlin mechmerlin commented Feb 5, 2019 •
edited
Loading

Description

The physical matrix defined in tmo50.h did not match the actual physical layout of the board. It actually matched the switch matrix (electrical matrix) defined in the bottom half of the LAYOUT macro minus the unused keys.

This led to 4 issues

  1. Column of the top row was off by 1
  2. One less key on the top row
  3. One more key on the bottom row
  4. The 2nd key on the top row (from left to right) was not defined correctly so you would have to edit your keymap to account for that.

Fixes:

  • Redo the physical matrix to match the physical layout of the board
  • Use K(row)(col) notation in hexadecimal
  • Amend default keymap to account for the new physical layout change
  • Add an additional LAYOUT macro to consider the 6.25u spacebar case

Types of changes

  • Core
  • Bugfix
  • New Feature
  • Enhancement/Optimization
  • Keyboard (addition or update)
  • Keymap/Layout/Userspace (addition or update)
  • Documentation

Issues Fixed or Closed by this PR

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document. (https://docs.qmk.fm/#/contributing)
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@drashna
Copy link
Member

drashna commented Feb 5, 2019

Thanks!

@drashna drashna merged commit b973258 into qmk:master Feb 5, 2019
@mechmerlin mechmerlin deleted the feature/tmo50_matrix_fix branch February 15, 2019 03:47
zer09 pushed a commit to zer09/qmk_firmware that referenced this pull request Feb 16, 2019
@mechmerlin @zer09
[Keyboard] TMO50 Off By 1 Column Bug (qmk#5055)
f2eeb43 
* fix a bug in which the physical matrix did not match the physical layout. Top row was missing 1 key and bottom row had 1 extra key

* amend keymap to account for the new physical matrix

* 6.25u space bar is actually supported, so add a new layout that supports this

* fix keymap readme to no longer need the cautionary warning
dlhextall pushed a commit to dlhextall/qmk_firmware that referenced this pull request May 24, 2019
@mechmerlin
[Keyboard] TMO50 Off By 1 Column Bug (qmk#5055)
93897af 
* fix a bug in which the physical matrix did not match the physical layout. Top row was missing 1 key and bottom row had 1 extra key

* amend keymap to account for the new physical matrix

* 6.25u space bar is actually supported, so add a new layout that supports this

* fix keymap readme to no longer need the cautionary warning
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug keyboard keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mechmerlin @drashna