Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1up60hte hhkb layout support #5050

Merged
merged 10 commits into from
Feb 4, 2019
Merged

Conversation

bubnick
Copy link
Contributor

@bubnick bubnick commented Feb 4, 2019

Description

Support for HHKB-style layout for 1upkeyboards HTE PCB

As well as minor keymap fixes for the default layout for the same board.

Types of changes

  • Core
  • Bugfix
  • New Feature
  • Enhancement/Optimization
  • Keyboard (addition or update)
  • Keymap/Layout/Userspace (addition or update)
  • Documentation

Issues Fixed or Closed by this PR

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document. (https://docs.qmk.fm/#/contributing)
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@mechmerlin
Copy link
Contributor

Also, I noticed this board doesn't have a readme.md would you mind putting one in using a template like the ones in the other 1upkeyboards keyboards?

@mechmerlin mechmerlin merged commit e14df86 into qmk:master Feb 4, 2019
zer09 pushed a commit to zer09/qmk_firmware that referenced this pull request Feb 16, 2019
* Tweaks to default 1up60hte layout + support for HHKB style layout

* Added changes to layouts

* Fix config.h

* Fixed errant KC_NO in layout

* Added readme to keyboard... Will update with images/store link when avail.

* Update to use LAYOUT_60_hhkb default layout

* md formatting fix

* Update keyboards/1upkeyboards/1up60hte/readme.md

Co-Authored-By: bubnick <[email protected]>

* Update keyboards/1upkeyboards/1up60hte/readme.md

Co-Authored-By: bubnick <[email protected]>

* Added layout to rules.mk, fixed layout to be compatble with community HHKB keymaps
dlhextall pushed a commit to dlhextall/qmk_firmware that referenced this pull request May 24, 2019
* Tweaks to default 1up60hte layout + support for HHKB style layout

* Added changes to layouts

* Fix config.h

* Fixed errant KC_NO in layout

* Added readme to keyboard... Will update with images/store link when avail.

* Update to use LAYOUT_60_hhkb default layout

* md formatting fix

* Update keyboards/1upkeyboards/1up60hte/readme.md

Co-Authored-By: bubnick <[email protected]>

* Update keyboards/1upkeyboards/1up60hte/readme.md

Co-Authored-By: bubnick <[email protected]>

* Added layout to rules.mk, fixed layout to be compatble with community HHKB keymaps
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants