Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix XD87 ANSI layout values #5031

Merged
merged 1 commit into from
Feb 4, 2019
Merged

Fix XD87 ANSI layout values #5031

merged 1 commit into from
Feb 4, 2019

Conversation

joshforisha
Copy link
Contributor

@joshforisha joshforisha commented Feb 1, 2019 •
edited
Loading

The tkl_ansi for the XD87 was not properly configured for the effective layout.

Description

The tkl_ansi layout had a typo (an unneeded K01) and an extra KC_NO than it should. This fix removes the typo and adds the missing K1C key.

Types of changes

  • Core
  • Bugfix
  • New Feature
  • Enhancement/Optimization
  • Keyboard (addition or update)
  • Keymap/Layout/Userspace (addition or update)
  • Documentation

Issues Fixed or Closed by this PR

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document. (https://docs.qmk.fm/#/contributing)
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@joshforisha
Fix XD87 ANSI layout values
2e67a60 
The tkl_ansi layout had an incorrect value for the grave/tilde key, and
number row keys were misnumbered. This fix removes the typo and adds the
missing K1C key.
mechmerlin
mechmerlin approved these changes Feb 4, 2019
View reviewed changes
Copy link
Contributor

@mechmerlin mechmerlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mechmerlin mechmerlin merged commit ab57965 into qmk:master Feb 4, 2019
zer09 pushed a commit to zer09/qmk_firmware that referenced this pull request Feb 16, 2019
@joshforisha @zer09
Fix XD87 ANSI layout values (qmk#5031)
5e43f9a 
The tkl_ansi layout had an incorrect value for the grave/tilde key, and
number row keys were misnumbered. This fix removes the typo and adds the
missing K1C key.
dlhextall pushed a commit to dlhextall/qmk_firmware that referenced this pull request May 24, 2019
@joshforisha
Fix XD87 ANSI layout values (qmk#5031)
e213083 
The tkl_ansi layout had an incorrect value for the grave/tilde key, and
number row keys were misnumbered. This fix removes the typo and adds the
missing K1C key.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mechmerlin mechmerlin mechmerlin approved these changes

Assignees
No one assigned
Labels
keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joshforisha @mechmerlin @drashna