Add samuel's literate keymap file for planck #4998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drashna
requested changes
Jan 30, 2019
|
Hello, please take as long as you need for this PR, but I just wanted to communicate that my last commit addressed issues raised in @drashna 's review. Please tell me if anything still needs to be looked at again, thank you. Additionally, the commits get squashed if it gets accepted right? When I made those commits I didn't expect to make this PR so I couldn't imagine them being very useful to anyone. |
|
The only remaining issue is a coding convention (formatting) one. As is, it's pretty hard to read. If you're fine with that, then that's okay. And yes, we squash keymap PRs, like this. |
|
I am fine with the formatting. I and other emacs users if they so choose to use this keymap will never look at the keymap file, but only at the org file. Thanks! |
dlhextall
pushed a commit
to dlhextall/qmk_firmware
that referenced
this pull request
May 24, 2019
* added my own keymap * changed thing * updated keymap Samuel * updated laypout for better one handed use * updated stuff I want * happy with my lagout * formatting * Added new literate config * made everything nice * cleaned * fixed spelling and two small bugs in macros * Made press and lift function for modifiers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added my awesome keymap written in a .org file for emacs users mostly. This way, you can easily edit your keymap in the org mode table, and changes will be reflected in the actual tethered keymap file. No more having to maintain comments and balancing tables to have a neat config file.
The actual keymap is not that important, just allowing other's to easily create their own keymaps in org if they wish. But if you are interested in the keymap, it is heavily based on a standard dvorak layout using a single extra layer and a lot of custom implemented tap keys to make it all work. It feels amazing!!!
Types of changes
Checklist: