Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for using ranges for RGB #4981

Merged
merged 2 commits into from
Feb 15, 2019
Merged

Conversation

Erovia
Copy link
Member

@Erovia Erovia commented Jan 28, 2019

This patch adds support for controlling continuous ranges of RGB LEDs.
Helper functions for split boards are also available.
New functions are also present in the documentation.

This patch adds support for controlling continuous ranges of RGB LEDs.
Helper functions for split boards are also available.
@drashna
Copy link
Member

drashna commented Jan 29, 2019

The *_master and *_slave` functions should probably be wrapped by ifdef's, so that they don't do anything on non-split keyboards.

Also.... I don't think they will work on i2c split boards, because of how the code is set, but I could be wrong.

@Erovia
Copy link
Member Author

Erovia commented Jan 29, 2019

The *_master and *_slave` functions should probably be wrapped by ifdef's, so that they don't do anything on non-split keyboards.

Also.... I don't think they will work on i2c split boards, because of how the code is set, but I could be wrong.

I thought about it, but wasn't sure what condition to use. "SPLIT_KEYBOARD" is not yet present in every split's rules.mk, is it?
Anyway, they only control the first/second half of the LEDs, so I don't think they cause much trouble.
(or maybe I'm just naive :D)

I could only test the code on a Let's Split rev2, which afaik uses i2c and it works fine.

@Erovia
Copy link
Member Author

Erovia commented Jan 31, 2019

@drashna, does this PR needs anyting else?

Copy link
Contributor

@mechmerlin mechmerlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mechmerlin mechmerlin merged commit 642f6cf into qmk:master Feb 15, 2019
dlhextall pushed a commit to dlhextall/qmk_firmware that referenced this pull request May 24, 2019
* Add support for using ranges for RGB

This patch adds support for controlling continuous ranges of RGB LEDs.
Helper functions for split boards are also available.

* RGB Range: Use hardware-platform agnostic wait
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants